You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2006/07/17 08:57:13 UTC

DO NOT REPLY [Bug 40054] New: - ab performance improvements

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40054>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40054

           Summary: ab performance improvements
           Product: Apache httpd-2
           Version: 2.0-HEAD
          Platform: Other
        OS/Version: other
            Status: NEW
          Keywords: PatchAvailable
          Severity: normal
          Priority: P2
         Component: support
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: braddr@puremagic.com


I've been playing with ab on one of sun's t2000's and the slowness of the
individual threads + some inefficiencies in ab combine for some amount of pain.
 One of the obvious sources are unecessary struct copying.  I'll attach a patch
to fix that next.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 40054] - ab performance improvements

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40054>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40054





------- Additional Comments From braddr@puremagic.com  2006-07-17 06:57 -------
Created an attachment (id=18608)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18608&action=view)
remove unnecessary structure copies


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 40054] - ab performance improvements

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40054>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40054





------- Additional Comments From braddr@puremagic.com  2006-07-17 10:11 -------
The biggest time sync's are pollset manipulation:

  %   cumulative   self              self     total           
 time   seconds   seconds    calls   s/call   s/call  name    
 10.72      0.97     0.97   400000     0.00     0.00  apr_pollset_add
  7.29      1.63     0.66        1     0.66     8.77  test
  6.85      2.25     0.62   171963     0.00     0.00  apr_pollset_poll
  6.41      2.83     0.58   100000     0.00     0.00  close_connection
  6.30      3.40     0.57   200000     0.00     0.00  apr_pollset_remove
  6.19      3.96     0.56   600000     0.00     0.00  get_epoll_event
  5.52      4.46     0.50   200000     0.00     0.00  read_connection
  4.53      4.87     0.41   771966     0.00     0.00  apr_time_now
  4.31      5.26     0.39   300000     0.00     0.00  get_epoll_revent
  4.20      5.64     0.38   200000     0.00     0.00  apr_socket_connect
  4.09      6.01     0.37   200000     0.00     0.00  apr_socket_recv
  4.09      6.38     0.37   100003     0.00     0.00  start_connect
  3.54      6.70     0.32   100000     0.00     0.00  write_request
  3.09      6.98     0.28   400040     0.00     0.00  apr_palloc
  2.76      7.23     0.25   200000     0.00     0.00  apr_socket_send
  2.65      7.47     0.24                             __divdi3
  1.99      7.65     0.18   100000     0.00     0.00  alloc_socket
  1.66      7.80     0.15   100000     0.00     0.00  apr_socket_timeout_set
  1.55      7.94     0.14   100000     0.00     0.00  set_socket_vars
  1.44      8.07     0.13   100000     0.00     0.00  apr_socket_create
  1.44      8.20     0.13   100000     0.00     0.00  socket_cleanup
  1.33      8.32     0.12   200001     0.00     0.00  apr_sockaddr_vars_set
  1.22      8.43     0.11   100010     0.00     0.00  apr_pool_cleanup_register
  1.22      8.54     0.11   100001     0.00     0.00  apr_pool_cleanup_kill
  1.10      8.64     0.10   100000     0.00     0.00  sononblock
  1.10      8.74     0.10    99997     0.00     0.00  apr_pool_clear
  0.88      8.82     0.08   100001     0.00     0.00  apr_pool_cleanup_run
  0.88      8.90     0.08   100000     0.00     0.00  apr_socket_opt_set
  0.66      8.96     0.06   100003     0.00     0.00  run_cleanups
  0.55      9.01     0.05   100000     0.00     0.00  apr_socket_close
  0.44      9.05     0.04                             __floatdisf
  0.00      9.05     0.00   100003     0.00     0.00  free_proc_chain

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 40054] - ab performance improvements

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40054>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40054





------- Additional Comments From braddr@puremagic.com  2006-07-17 09:58 -------
I re-ran my performance tests tonight, both with 2.0.55 and trunk, both with and
with out compiling with -pg.  I no longer see the performance benefits I saw
when I did those changes.  I'm not sure what's up at the moment.

One simple change that buys 100 tps with -pg is not to completely destroy/create
the pool, just clear it out:

@@ -1129,8 +1129,9 @@
     c->gotheader = 0;
     c->rwrite = 0;
     if (c->ctx)
-        apr_pool_destroy(c->ctx);
-    apr_pool_create(&c->ctx, cntxt);
+        apr_pool_clear(c->ctx);
+    else
+        apr_pool_create(&c->ctx, cntxt);
 
     if ((rv = apr_socket_create(&c->aprsock, destsa->family,



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org