You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by harshach <gi...@git.apache.org> on 2014/11/20 02:08:47 UTC
[GitHub] storm pull request: STORM-563. Kafka Spout doesn't pick up from th...
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/321
STORM-563. Kafka Spout doesn't pick up from the beginning of the queue unless forceFromStart specified.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-563
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #321
----
commit ecfa7d0825ca0c8e01ed1f97774015c1dd509d65
Author: Sriharsha Chintalapani <ma...@harsha.io>
Date: 2014-11-20T01:07:27Z
STORM-563. Kafka Spout doesn't pick up from the beginning of the queue unless forceFromStart specified.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-563. Kafka Spout doesn't pick up from th...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/321#issuecomment-75573879
@harshach would you like to provide update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-563. Kafka Spout doesn't pick up from th...
Posted by nathanmarz <gi...@git.apache.org>.
Github user nathanmarz commented on the pull request:
https://github.com/apache/storm/pull/321#issuecomment-63757949
That doesn't look right. That change makes the if statement there meaningless. That method should just be removed, and the other getOffset method should be changed to:
```
public static long getOffset(SimpleConsumer consumer, String topic, int partition, Long startOffsetTime) {
if(startOffsetTime==null) startOffsetTime = kafka.api.OffsetRequest.LatestTime();
// the rest the same
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-563. Kafka Spout doesn't pick up from th...
Posted by harshach <gi...@git.apache.org>.
Github user harshach closed the pull request at:
https://github.com/apache/storm/pull/321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-563. Kafka Spout doesn't pick up from th...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/321#issuecomment-63761302
@nathanmarz rethinking a bit on this patch. Having both startOffsetTime and forceFromStart is confusing a bit from user point of view. If user deploys a topology and doesn't set forceFromStart and by default startOffsetTime is EarliestTime. It doesn't read from the beginning of the queue.
If the user sets forceFromStart to true and later kills the topology and redeploys it they must remember to turn off the forceFromStart to start from where they left off. I'll send a updated patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-563. Kafka Spout doesn't pick up from th...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/321#issuecomment-75575308
@kishorvpatil this JIRA will be addressed as part of STORM-650 refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---