You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/04 02:14:38 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4073: Display network name for IP in shared networks

rhtyd commented on a change in pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#discussion_r434953602



##########
File path: api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java
##########
@@ -150,6 +150,10 @@
     @Param(description = "is public ip for display to the regular user", since = "4.4", authorized = {RoleType.Admin})
     private Boolean forDisplay;
 
+    @SerializedName("networkname")

Review comment:
       @ravening can you change that to use `ApiConstants`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org