You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/07/22 09:43:26 UTC
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #944: IGNITE-16870 Extend Schema with ability to specify function as default value generator
AMashenkov commented on code in PR #944:
URL: https://github.com/apache/ignite-3/pull/944#discussion_r927483579
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java:
##########
@@ -80,15 +79,15 @@ public Column(
* @param name Column name.
* @param type An instance of column data type.
* @param nullable If {@code false}, null values will not be allowed for this column.
- * @param defValSup Default value supplier.
+ * @param defaultValueProvider Default value supplier.
*/
public Column(
String name,
NativeType type,
boolean nullable,
- @NotNull Supplier<Object> defValSup
+ @NotNull DefaultValueProvider defaultValueProvider
Review Comment:
```suggestion
DefaultValueProvider defaultValueProvider
```
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java:
##########
@@ -115,16 +114,16 @@ public Column(
* @param name Column name.
* @param type An instance of column data type.
* @param nullable If {@code false}, null values will not be allowed for this column.
- * @param defValSup Default value supplier.
+ * @param defaultValueProvider Default value supplier.
*/
public Column(
int columnOrder,
String name,
NativeType type,
boolean nullable,
- @NotNull Supplier<Object> defValSup
+ @NotNull DefaultValueProvider defaultValueProvider
Review Comment:
```suggestion
DefaultValueProvider defaultValueProvider
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org