You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sunng87 (via GitHub)" <gi...@apache.org> on 2023/02/17 07:24:05 UTC
[GitHub] [arrow-datafusion] sunng87 opened a new pull request, #5318: feat: add accessor to SessionContext fields for ContextProvider impl
sunng87 opened a new pull request, #5318:
URL: https://github.com/apache/arrow-datafusion/pull/5318
# Which issue does this PR close?
Closes #5317
# Rationale for this change
As described in #5317 , accessors are need in new `SessionContext` api.
# What changes are included in this PR?
# Are these changes tested?
Changes are dead simple
# Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5318: feat: add accessor to SessionContext fields for ContextProvider impl
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5318:
URL: https://github.com/apache/arrow-datafusion/pull/5318#issuecomment-1434762686
Thank you @sunng87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5318: feat: add accessor to SessionContext fields for ContextProvider impl
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5318:
URL: https://github.com/apache/arrow-datafusion/pull/5318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5318: feat: add accessor to SessionContext fields for ContextProvider impl
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5318:
URL: https://github.com/apache/arrow-datafusion/pull/5318#issuecomment-1434767282
Not sure if it helps your usecase, but here is how we di this in IOx (https://github.com/influxdata/influxdb_iox/blob/bda2310ca1a5ac385a88f623a8bbe7f4c9b96f39/query_functions/src/lib.rs#L99-L105) -- aka create the function registry and then pass it to the SessionContext rather than modify the existing session context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sunng87 commented on pull request #5318: feat: add accessor to SessionContext fields for ContextProvider impl
Posted by "sunng87 (via GitHub)" <gi...@apache.org>.
sunng87 commented on PR #5318:
URL: https://github.com/apache/arrow-datafusion/pull/5318#issuecomment-1435673753
Thank you for your example, @alamb !
In our case, we have our own `SessionContext` and `SessionState` equivalents by wrapping the original implementation and adding our own logic. In order to fit into datafusion, we impl `ContextProvider` for our types. And functions in `ContextProvider` require access to these values of `SessionState`, which just changed from public to private in recent versions of df.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5318: feat: add accessor to SessionContext fields for ContextProvider impl
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5318:
URL: https://github.com/apache/arrow-datafusion/pull/5318#issuecomment-1435708075
Benchmark runs are scheduled for baseline = c5108aef4d2660cce950976af14d33444f27075e and contender = 5d5b1a0bd8234465d179adc0b947bb439acc91f7. 5d5b1a0bd8234465d179adc0b947bb439acc91f7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/93b7c89e668d4880b647b452ec940fee...ec1de7ae689f4747983a442706fe604a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e1b0c784461843378a5a29295280a438...916eade7fdeb4acd94df3ae267fb80d4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d8506e8a8bd8468693e67468ec65d7d0...e04efdc339434d4dbf5f494109ecac58/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/81e07dd6210b46fc8fc056bf2d1a95be...938cd0f32dbe48fc8fcfbd51ce47c830/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org