You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/02 16:30:48 UTC

Review Request 38056: Fix webui task informations not update bug.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/
-----------------------------------------------------------

Review request for mesos, Adam B and Ross Allen.


Repository: mesos


Description
-------

Fix webui task informations not update bug.


Diffs
-----

  src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 

Diff: https://reviews.apache.org/r/38056/diff/


Testing
-------

Manual test, test scenarios:
* Normal scenarios updated after the new task is finished
* After mesos-master down, could updated after reconnected


Thanks,

haosdent huang


Re: Review Request 38056: Fix webui task informations not update bug.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review97470
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38056]

All tests passed.

- Mesos ReviewBot


On Sept. 2, 2015, 2:30 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 2:30 p.m.)
> 
> 
> Review request for mesos, Adam B and Ross Allen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> -------
> 
> Manual test, test scenarios:
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38056: Fix webui task informations not update bug.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review98425
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38056]

All tests passed.

- Mesos ReviewBot


On Sept. 10, 2015, 4:51 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 4:51 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-3282
>     https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js fbf86965efdb16f11787c24fb50d20af0837c62d 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> -------
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38056: Fix webui task informations not update bug.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/
-----------------------------------------------------------

(Updated Sept. 10, 2015, 4:51 p.m.)


Review request for mesos, Adam B and Michael Park.


Changes
-------

Rebase.


Bugs: MESOS-3282
    https://issues.apache.org/jira/browse/MESOS-3282


Repository: mesos


Description
-------

Fix webui task informations not update bug.


Diffs (updated)
-----

  src/webui/master/static/js/controllers.js fbf86965efdb16f11787c24fb50d20af0837c62d 

Diff: https://reviews.apache.org/r/38056/diff/


Testing (updated)
-------

Manual test, test scenarios:

* Normal scenarios updated after the new task is finished
* After mesos-master down, could updated after reconnected

![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)


Thanks,

haosdent huang