You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/04/12 15:51:39 UTC
Review Request 58389: Log Search: Add get clusters endpoint for
service and audit logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58389/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert Nettleton.
Bugs: AMBARI-20744
https://issues.apache.org/jira/browse/AMBARI-20744
Repository: ambari
Description
-------
Add endpoint to get clusters for service and audit log collection.
As the cluster fields can be different, therefore we need 2 calls for that
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 984e834
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 49465d5
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 6b40cb5
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java 9ce209b
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java 2013dc7
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java 498da69
Diff: https://reviews.apache.org/r/58389/diff/1/
Testing
-------
done. manually
Thanks,
Oliver Szabo
Re: Review Request 58389: Log Search: Add get clusters endpoint for
service and audit logs
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58389/#review171809
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On April 12, 2017, 3:51 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58389/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 3:51 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert Nettleton.
>
>
> Bugs: AMBARI-20744
> https://issues.apache.org/jira/browse/AMBARI-20744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add endpoint to get clusters for service and audit log collection.
> As the cluster fields can be different, therefore we need 2 calls for that
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 984e834
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 49465d5
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 6b40cb5
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java 9ce209b
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java 2013dc7
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java 498da69
>
>
> Diff: https://reviews.apache.org/r/58389/diff/1/
>
>
> Testing
> -------
>
> done. manually
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58389: Log Search: Add get clusters endpoint for
service and audit logs
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58389/#review171782
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 12, 2017, 3:51 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58389/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 3:51 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert Nettleton.
>
>
> Bugs: AMBARI-20744
> https://issues.apache.org/jira/browse/AMBARI-20744
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add endpoint to get clusters for service and audit log collection.
> As the cluster fields can be different, therefore we need 2 calls for that
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java 984e834
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 49465d5
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 6b40cb5
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java 9ce209b
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java 2013dc7
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java 498da69
>
>
> Diff: https://reviews.apache.org/r/58389/diff/1/
>
>
> Testing
> -------
>
> done. manually
>
>
> Thanks,
>
> Oliver Szabo
>
>