You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/29 18:29:54 UTC

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9685: [fix] reduce table metadata fetch for latest_partition check

graceguo-supercat commented on a change in pull request #9685:
URL: https://github.com/apache/incubator-superset/pull/9685#discussion_r417524517



##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -125,9 +128,10 @@ export default class AdhocFilterControl extends React.Component {
                 );
               }
             }
-          },
-          // no error handler, in case of error do not show partition option
-        );
+          })
+          .catch(error => {
+            console.log('fetch extra_table_metadata:', error.statusText);

Review comment:
       fixed. console.error is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org