You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/06 15:04:17 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #34929: [SPARK-37670][SQL] Support predicate pushdown and column pruning for de-duped CTEs
cloud-fan commented on a change in pull request #34929:
URL: https://github.com/apache/spark/pull/34929#discussion_r779611578
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1012,6 +1016,24 @@ class Analyzer(override val catalogManager: CatalogManager)
// inside a view maybe resolved incorrectly.
checkAnalysis(newChild)
view.copy(child = newChild)
+ case view @ View(_, _, child) =>
Review comment:
Let's add a comment before this case
```
// This is DataFrame view, not SQL view. We need to reassign CTE IDs as the plan
// is already resolved but the CTE IDs may conflict with main query.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org