You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/11/07 02:08:31 UTC

[kudu-CR] [util] fix compilation warning

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20671


Change subject: [util] fix compilation warning
......................................................................

[util] fix compilation warning

This patch fixes compilation warning produced by GCC:

  src/kudu/util/env_posix.cc:484:22: warning: format ‘%x’ expects
      argument of type ‘unsigned int’, but argument 2 has type
      ‘kudu::{anonymous}::EncryptionAlgorithm’ [-Wformat=]
          StringPrintf("no cipher for algorithm 0x%02x", eh->algorithm));

I also wrapped the results of GetEVPCipher() into PREDICT_FALSE() macro.

Change-Id: I040c26a3d6d0e9b5350053848a12b4860ab9be4a
---
M src/kudu/util/env_posix.cc
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/20671/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I040c26a3d6d0e9b5350053848a12b4860ab9be4a
Gerrit-Change-Number: 20671
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [util] fix compilation warning

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20671 )

Change subject: [util] fix compilation warning
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I040c26a3d6d0e9b5350053848a12b4860ab9be4a
Gerrit-Change-Number: 20671
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 07 Nov 2023 02:44:57 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix compilation warning

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20671 )

Change subject: [util] fix compilation warning
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I040c26a3d6d0e9b5350053848a12b4860ab9be4a
Gerrit-Change-Number: 20671
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 07 Nov 2023 04:23:32 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix compilation warning

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20671 )

Change subject: [util] fix compilation warning
......................................................................

[util] fix compilation warning

This patch fixes compilation warning produced by GCC:

  src/kudu/util/env_posix.cc:484:22: warning: format ‘%x’ expects
      argument of type ‘unsigned int’, but argument 2 has type
      ‘kudu::{anonymous}::EncryptionAlgorithm’ [-Wformat=]
          StringPrintf("no cipher for algorithm 0x%02x", eh->algorithm));

I also wrapped the results of GetEVPCipher() into PREDICT_FALSE() macro.

Change-Id: I040c26a3d6d0e9b5350053848a12b4860ab9be4a
Reviewed-on: http://gerrit.cloudera.org:8080/20671
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
---
M src/kudu/util/env_posix.cc
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Yifan Zhang: Looks good to me, approved
  Kudu Jenkins: Verified
  Mahesh Reddy: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/20671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I040c26a3d6d0e9b5350053848a12b4860ab9be4a
Gerrit-Change-Number: 20671
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>