[GitHub] [arrow-rs] roeap commented on a diff in pull request #4250: feat: update flight-sql to latest specs

["roeap (via GitHub)" <gi...@apache.org>]

roeap commented on code in PR #4250:
URL: https://github.com/apache/arrow-rs/pull/4250#discussion_r1200423796


##########
arrow-flight/src/sql/server.rs:
##########
@@ -529,9 +656,108 @@ where
                         "Unable to unpack ActionClosePreparedStatementRequest.",
                     )
                 })?;
-            self.do_action_close_prepared_statement(cmd, request).await;
+            self.do_action_close_prepared_statement(cmd, request)
+                .await?;
             return Ok(Response::new(Box::pin(futures::stream::empty())));
         }
+        if request.get_ref().r#type == CREATE_PREPARED_SUBSTRAIT_PLAN {

Review Comment:
   just matched what was there ... but yes, adding some `else`s makes much more sene :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org