You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/10/04 05:35:50 UTC

[GitHub] jlahoda opened a new pull request #941: For multi-release modular jars, use the newest module-info available …

jlahoda opened a new pull request #941: For multi-release modular jars, use the newest module-info available …
URL: https://github.com/apache/incubator-netbeans/pull/941
 
 
   …when detecting module name.
   
   This should solve the problem with log4j. Should be cherry-picked to release100, if approved/accepted.
   
   There's one thing that is not completely correct: the problematic method does not know the source level, so it cannot decide which versioned module-info it should use. So it always uses the module-info for the newest platform version, which may not be always correct. But given the method only needs the module name, and changing the module name using multi-release jar feels like a bad idea, this may be fine in almost all cases.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists