Re: [PR] fix: Optimize read_side_padding" [datafusion-comet]

["kazuyukitanimura (via GitHub)" <gi...@apache.org>]

kazuyukitanimura commented on code in PR #772:
URL: https://github.com/apache/datafusion-comet/pull/772#discussion_r1708167370


##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1911,6 +1911,18 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
     }
   }
 
+  test("readSidePadding") {
+    // https://stackoverflow.com/a/46290728
+    val table = "test"
+    withTable(table) {
+      sql(s"create table $table(col1 CHAR(2)) using parquet")
+      sql(s"insert into $table values('é')") // unicode 'e\\u{301}'
+      sql(s"insert into $table values('é')") // unicode '\\u{e9}'

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org