You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/07/10 08:04:29 UTC
[GitHub] incubator-zeppelin pull request: Switch ngDelete to ngEscape
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/149
Switch ngDelete to ngEscape
When IBM-compatible keyboards user presses `Delete` key, it updates title of notebook/paragraph instead of forward delete.
This PR fix this bug by removing delete key event.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin switch_ngdelete_to_ng_escape
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit c34ee593891a1f64e4f46de7807779bf58b61f32
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-07-10T05:36:50Z
Switch ngDelete to ngEscape
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch ngDelete to ngEscape
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/149#issuecomment-120656239
Tested and LGTM! Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch ngDelete to ngEscape
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---