You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/10/06 06:49:26 UTC
[PR] feat(core): Move jib plugins versions to camelcatalog [camel-k]
gansheer opened a new pull request, #4805:
URL: https://github.com/apache/camel-k/pull/4805
Ref #4703
## Description
Extracted jib plugin versions to camel-k-runtime:
* use camelcatalog CR .spec.runtime.metadata values
* set default values for catalog backward compatibility
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat(core): Move jib plugins versions to camelcatalog from camel-k-runtime
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Move jib plugins versions to camelcatalog [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4805:
URL: https://github.com/apache/camel-k/pull/4805#issuecomment-1750085510
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Move jib plugins versions to camelcatalog [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4805:
URL: https://github.com/apache/camel-k/pull/4805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Move jib plugins versions to camelcatalog [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4805:
URL: https://github.com/apache/camel-k/pull/4805#issuecomment-1750123297
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Move jib plugins versions to camelcatalog [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4805:
URL: https://github.com/apache/camel-k/pull/4805#issuecomment-1750127081
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Move jib plugins versions to camelcatalog [camel-k]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4805:
URL: https://github.com/apache/camel-k/pull/4805#issuecomment-1750086434
:camel: **Thank you for contributing!**
Code Coverage Report :heavy_check_mark: - Coverage unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): Move jib plugins versions to camelcatalog [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4805:
URL: https://github.com/apache/camel-k/pull/4805#discussion_r1348331747
##########
pkg/util/jib/configuration.go:
##########
@@ -50,8 +53,8 @@ type JibProfile struct {
}
// Create a Configmap containing the default jib profile.
-func CreateProfileConfigmap(ctx context.Context, c client.Client, kit *v1.IntegrationKit) error {
- profile, err := jibMavenProfile()
+func CreateProfileConfigmap(ctx context.Context, c client.Client, catalog *camel.RuntimeCatalog, kit *v1.IntegrationKit) error {
Review Comment:
In order to reduce the coupling, I'd instead create the profile externally and pass it in this func instead of the catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org