You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/04 13:06:11 UTC
[GitHub] [spark] yaooqinn opened a new pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveO…
yaooqinn opened a new pull request #31013:
URL: https://github.com/apache/spark/pull/31013
…peratorsUpWithNewOutput
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In https://github.com/apache/spark/pull/29643, we move Move the plan rewriting methods to QueryPlan. we need to add allowInvokingTransformsInAnalyzer to resolveOperatorsUpWithNewOutput as it is called in the analyzer.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
trivial bugfix
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754153761
This looks okay but maybe clean up the PR title and description a little bit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754320838
**[Test build #133609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133609/testReport)** for PR 31013 at commit [`b875566`](https://github.com/apache/spark/commit/b8755663410c284f65368788992d18aca54e1383).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754344784
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38198/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754334322
@viirya thanks for reminding me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754444569
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133609/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31013:
URL: https://github.com/apache/spark/pull/31013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31013:
URL: https://github.com/apache/spark/pull/31013#discussion_r551336216
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala
##########
@@ -451,6 +451,21 @@ trait CharVarcharTestSuite extends QueryTest with SQLTestUtils {
Seq(Row("char(5)"), Row("varchar(3)")))
}
}
+
+ test("SPARK-33992: char/varchar resolution in correlated sub query ") {
+ withTable("t1", "t2") {
+ sql(s"CREATE TABLE t1(v VARCHAR(3), c CHAR(5)) USING $format")
+ sql(s"CREATE TABLE t2(v VARCHAR(3), c CHAR(5)) USING $format")
+ sql("INSERT INTO t1 VALUES ('c', 'b')")
+ sql("INSERT INTO t2 VALUES ('a', 'b')")
+
+ checkAnswer(sql(
+ """
+ |SELECT v FROM t1
+ | WHERE 'a' IN (SELECT v FROM t2 WHERE t1.c = t2.c )""".stripMargin),
Review comment:
nit: `| WHERE 'a' IN` -> `|WHERE 'a' IN`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31013:
URL: https://github.com/apache/spark/pull/31013#discussion_r551335697
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala
##########
@@ -451,6 +451,21 @@ trait CharVarcharTestSuite extends QueryTest with SQLTestUtils {
Seq(Row("char(5)"), Row("varchar(3)")))
}
}
+
+ test("SPARK-33992: char/varchar resolution in correlated sub query ") {
Review comment:
`branch-3.0` has the same issue? The branch does not have `PaddingAndLengthCheckForCharVarchar` though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31013:
URL: https://github.com/apache/spark/pull/31013#discussion_r551335998
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala
##########
@@ -451,6 +451,21 @@ trait CharVarcharTestSuite extends QueryTest with SQLTestUtils {
Seq(Row("char(5)"), Row("varchar(3)")))
}
}
+
+ test("SPARK-33992: char/varchar resolution in correlated sub query ") {
Review comment:
nit: remove the unnecessary space in the end: `in correlated sub query ")` -> `in correlated sub query")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754360636
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38198/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754320838
**[Test build #133609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133609/testReport)** for PR 31013 at commit [`b875566`](https://github.com/apache/spark/commit/b8755663410c284f65368788992d18aca54e1383).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754408066
GA passed, merging to master/3.1!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754153761
This looks okay but maybe clean up the description a little bit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754360661
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38198/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754438060
**[Test build #133609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133609/testReport)** for PR 31013 at commit [`b875566`](https://github.com/apache/spark/commit/b8755663410c284f65368788992d18aca54e1383).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754444569
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133609/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-753985022
cc @cloud-fan @maropu @dongjoon-hyun thanks very much
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31013: [SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31013:
URL: https://github.com/apache/spark/pull/31013#issuecomment-754360661
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38198/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #31013: [SPARK-33992][SQL] Add allowInvokingTransformsInAnalyzer for resolveOperatorsUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31013:
URL: https://github.com/apache/spark/pull/31013#discussion_r551345852
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala
##########
@@ -451,6 +451,21 @@ trait CharVarcharTestSuite extends QueryTest with SQLTestUtils {
Seq(Row("char(5)"), Row("varchar(3)")))
}
}
+
+ test("SPARK-33992: char/varchar resolution in correlated sub query ") {
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org