You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/03 13:26:57 UTC

[GitHub] [incubator-nuttx] eenurkka opened a new pull request, #6776: risc-v/mpfs: usb: configure fifos properly

eenurkka opened a new pull request, #6776:
URL: https://github.com/apache/incubator-nuttx/pull/6776

   RX_FIFO_ADDRs and TX_FIFO_ADDR were misconfigured. These addresses
   overlapped causing data corruption during high USB loads. For
   example, data corruption was present during the following conditions:
   
     1. Composite USB driver was used (CDC/ACM + Mass storage)
     2. /dev/ttyACM0 was accessed instantly from Linux side when
        starting up.
     3. Training data was sent to /dev/ttyACM0 from NuttX from the
        very beginning periodically.
   
   It was observed that while Mass storage was negotiating, sometimes
   data sent from NuttX to Linux via CDC/ACM was corrupt, although it
   was sent properly on the TX fifo.
   
   Also, don't access TXCSRL_REG_EPN_TX_FIFO_NE_MASK for EP0 as it's
   not applicable.
   
   Signed-off-by: Eero Nurkkala <ee...@offcode.fi>
   
   ## Summary
   
   Fix random data corruption
   
   ## Impact
   
   MPFS/USB composite driver
   
   ## Testing
   
   Tested with mpfs Polarfire kit, wrote 1.9 GB image and used USB CDC/ACM with linux with test scripts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6776: risc-v/mpfs: usb: configure fifos properly

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6776:
URL: https://github.com/apache/incubator-nuttx/pull/6776


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org