You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2024/02/10 12:04:22 UTC
[PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
zentol opened a new pull request, #24296:
URL: https://github.com/apache/flink/pull/24296
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24296:
URL: https://github.com/apache/flink/pull/24296#issuecomment-1936990365
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8ed5e8fd96ad32030b0f34017b0871a4ef0338f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8ed5e8fd96ad32030b0f34017b0871a4ef0338f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8ed5e8fd96ad32030b0f34017b0871a4ef0338f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
Posted by "hanyuzheng7 (via GitHub)" <gi...@apache.org>.
hanyuzheng7 commented on PR #24296:
URL: https://github.com/apache/flink/pull/24296#issuecomment-1937097943
Hi, @zentol, it appears that Azure is failing the CI test, similar to the issue I'm encountering with my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24296:
URL: https://github.com/apache/flink/pull/24296#issuecomment-2777669086
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #24296:
URL: https://github.com/apache/flink/pull/24296#discussion_r1485848601
##########
tools/ci/compile.sh:
##########
@@ -79,6 +79,11 @@ if [ $EXIT_CODE != 0 ]; then
exit $EXIT_CODE
fi
+if [[ ${PROFILE} == *"-Dfast"* || ${PROFILE} == *"-Pfast"* ]]; then
Review Comment:
this should also take passed arguments into account 🤔 The duality or args being passed via profile _and_ arguments to compile.sh is a bit annoying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #24296:
URL: https://github.com/apache/flink/pull/24296#discussion_r1485848601
##########
tools/ci/compile.sh:
##########
@@ -79,6 +79,11 @@ if [ $EXIT_CODE != 0 ]; then
exit $EXIT_CODE
fi
+if [[ ${PROFILE} == *"-Dfast"* || ${PROFILE} == *"-Pfast"* ]]; then
Review Comment:
this should also take passed arguments into account 🤔 The duality or args being passed via profile _and_ arguments to compile.sh is a bit annoying (but currently can't be helped because compile_ci.sh isn't forwarding arguments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24296:
URL: https://github.com/apache/flink/pull/24296#issuecomment-2850026404
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34421] Skip post-compile checks if 'fast' profile is active [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #24296: [FLINK-34421] Skip post-compile checks if 'fast' profile is active
URL: https://github.com/apache/flink/pull/24296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org