You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/03/14 17:15:00 UTC

[jira] [Commented] (GEODE-4689) Improved mechanism to wait for partition region colocation to complete.

    [ https://issues.apache.org/jira/browse/GEODE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398913#comment-16398913 ] 

ASF subversion and git services commented on GEODE-4689:
--------------------------------------------------------

Commit d621b47d6d3bd9c6b285b37ca61a25e420b5fc83 in geode's branch refs/heads/develop from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d621b47 ]

GEODE-4689: Colocation complete listeners added (#1565)

        * PartitionRegion can now add a colocation listener to itself which is triggered when the colocation is completed.
	* Lucene indexRepositoryFactory adds colocation complete listener to the file region
	* when the colocation of the file region is completed the compute repository is called

> Improved mechanism to wait for partition region colocation to complete.
> -----------------------------------------------------------------------
>
>                 Key: GEODE-4689
>                 URL: https://issues.apache.org/jira/browse/GEODE-4689
>             Project: Geode
>          Issue Type: Sub-task
>          Components: lucene
>            Reporter: nabarun
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> File location : IndexRepositoryFactory.java
> Method : computeIndexRepository
> Code:
> {code:java}
> PartitionRegionConfig prConfig =
>     (PartitionRegionConfig) prRoot.get(fileRegion.getRegionIdentifier());
> while (!prConfig.isColocationComplete()) {
>   prConfig = (PartitionRegionConfig) prRoot.get(fileRegion.getRegionIdentifier());
> }
> {code}
>  
> Solution Acceptance :
> We should not  depend on an infinite while loop to wait for all partition region colocations to be completed.
> We should find a better way and use that to replace the code above.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)