[jira] [Commented] (ZOOKEEPER-2399) Partial Initial Patches to update Zookeeper trunk to Netty 4.x API

["Chris West (Faux) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355318#comment-16355318 ] 

Chris West (Faux) commented on ZOOKEEPER-2399:
----------------------------------------------

I pulled these patches into a branch: [https://github.com/apache/zookeeper/compare/master...FauxFaux:jira2399]

Unfortunately, the branch doesn't merge very cleanly at all, and there's a load of outstanding issues I don't have a solution to:

 * Traffic suspension has new, weird event semantics: https://netty.io/wiki/new-and-noteworthy-in-4.0.html#sensible-and-less-error-prone-inbound-traffic-suspension
 * `interestOps` is no-longer exposed directly, have to deal with keys directly?
 * A load of pool constructors now need explicit pools, which someone needs to decide values for.

...and more.
 

> Partial Initial Patches to update Zookeeper trunk to Netty 4.x API
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2399
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2399
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: William L Thomson Jr
>            Priority: Major
>         Attachments: ClientCnxnSocketNetty_java.patch, NettyServerCnxnFactory_java.patch, NettyServerCnxn_java.patch
>
>
> These are initial patches to update Zookeeper to Netty 4.x API. They are not complete, as I am not familiar with Zookeeper or Netty. I just used Netty documents that detailed the difference in the API to make the changes. I believe I am 80-90% of the way there, but need someone familiar with Zookeeper and/or Netty to finish the last part and make sure it actually works and I did not fubar Zookeeper :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)