You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/11/28 18:48:54 UTC

Re: Review Request 53770: CMake Cleanup: Alphabetize the list of sources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53770/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 10:48 a.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
-------

Rebase on the switchboard changes.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

This alphabetizes the sources by variable name, and then by filename.
A few missing files were added and some duplicate files were removed.


Diffs (updated)
-----

  src/CMakeLists.txt d6e213686a44fbca0ed841594ce803151224a5a7 

Diff: https://reviews.apache.org/r/53770/diff/


Testing
-------

This being the final review in the chain, I ran the cmake build on several systems:

cmake ..
make check (OSX)
make check (CentOS 7)

sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7)

These have reached parity with the automake build configured with `--disable-java --disable-python`.


Thanks,

Joseph Wu