You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/24 01:55:53 UTC

[GitHub] [incubator-dolphinscheduler] lenboo opened a new pull request #2003: [New Feature] add conditions task 

lenboo opened a new pull request #2003: [New Feature] add conditions task 
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003
 
 
   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   add new feature: conditions task
   
   ## Brief change log
   
   some refactor in master submit node;
   add worker runner 
   frontend changes
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590147105
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=h1) Report
   > Merging [#2003](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/9cf9ee391a676353a3d678cb25d79890ea02da31?src=pr&el=desc) will **increase** coverage by `1.11%`.
   > The diff coverage is `72.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##               dev    #2003      +/-   ##
   ===========================================
   + Coverage     30.6%   31.72%   +1.11%     
   - Complexity    1384     1512     +128     
   ===========================================
     Files          296      313      +17     
     Lines        15148    15528     +380     
     Branches      1832     1886      +54     
   ===========================================
   + Hits          4636     4926     +290     
   - Misses       10054    10092      +38     
   - Partials       458      510      +52
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/dolphinscheduler/common/enums/QueryType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1F1ZXJ5VHlwZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `70% <0%> (-3.69%)` | `11 <0> (ø)` | |
   | [...lphinscheduler/server/worker/task/TaskManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phinscheduler/server/worker/task/AbstractTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0VGFzay5qYXZh) | `11.59% <0%> (-0.35%)` | `2 <0> (ø)` | |
   | [...ommon/task/sqoop/sources/SourceMysqlParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3Avc291cmNlcy9Tb3VyY2VNeXNxbFBhcmFtZXRlci5qYXZh) | `100% <100%> (ø)` | `19 <19> (?)` | |
   | [...common/task/sqoop/sources/SourceHdfsParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3Avc291cmNlcy9Tb3VyY2VIZGZzUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `3 <3> (?)` | |
   | [...ommon/task/sqoop/targets/TargetMysqlParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRNeXNxbFBhcmFtZXRlci5qYXZh) | `100% <100%> (ø)` | `19 <19> (?)` | |
   | [...common/task/sqoop/targets/TargetHiveParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRIaXZlUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `17 <17> (?)` | |
   | [...common/task/sqoop/targets/TargetHdfsParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRIZGZzUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `13 <13> (?)` | |
   | [...apache/dolphinscheduler/common/enums/TaskType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Rhc2tUeXBlLmphdmE=) | `81.81% <100%> (+0.86%)` | `2 <0> (ø)` | :arrow_down: |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=footer). Last update [9cf9ee3...bcb2b17](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] break60 commented on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
break60 commented on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590148188
 
 
   frontend +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590702993
 
 
   1，compile error，plese re-run check or repair
   2，conflicts please resolve

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590277759
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C.png' alt='C' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [10 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list) [0.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590277759
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C.png' alt='C' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [10 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list) [0.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-591749989
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C.png' alt='C' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [10 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list) [0.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590145846
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B.png' alt='B' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [8 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list) [0.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590147541
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B.png' alt='B' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [8 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list) [0.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590147541
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B.png' alt='B' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [8 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list) [0.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590147105
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=h1) Report
   > Merging [#2003](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/34e0a663edbd01995c1e594b3b23a856db7b38a4?src=pr&el=desc) will **decrease** coverage by `0.23%`.
   > The diff coverage is `1.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##                dev   #2003      +/-   ##
   ===========================================
   - Coverage     30.84%   30.6%   -0.24%     
   - Complexity     1382    1384       +2     
   ===========================================
     Files           294     296       +2     
     Lines         15022   15148     +126     
     Branches       1810    1832      +22     
   ===========================================
   + Hits           4633    4636       +3     
   - Misses         9930   10054     +124     
   + Partials        459     458       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...r/common/task/conditions/ConditionsParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svY29uZGl0aW9ucy9Db25kaXRpb25zUGFyYW1ldGVycy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...e/dolphinscheduler/common/model/DependentItem.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL0RlcGVuZGVudEl0ZW0uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...lphinscheduler/server/worker/task/TaskManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...duler/server/worker/runner/TaskScheduleThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza1NjaGVkdWxlVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../server/worker/task/conditions/ConditionsTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2NvbmRpdGlvbnMvQ29uZGl0aW9uc1Rhc2suamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phinscheduler/server/worker/task/AbstractTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0VGFzay5qYXZh) | `11.94% <0%> (-0.37%)` | `2 <0> (ø)` | |
   | [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `73.68% <0%> (-4.1%)` | `11 <0> (ø)` | |
   | [...apache/dolphinscheduler/common/enums/TaskType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Rhc2tUeXBlLmphdmE=) | `80.95% <100%> (+0.95%)` | `2 <0> (ø)` | :arrow_down: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=footer). Last update [34e0a66...9cf9ee3](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590147105
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=h1) Report
   > Merging [#2003](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/9cf9ee391a676353a3d678cb25d79890ea02da31?src=pr&el=desc) will **increase** coverage by `1.11%`.
   > The diff coverage is `72.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##               dev    #2003      +/-   ##
   ===========================================
   + Coverage     30.6%   31.72%   +1.11%     
   - Complexity    1384     1512     +128     
   ===========================================
     Files          296      313      +17     
     Lines        15148    15528     +380     
     Branches      1832     1886      +54     
   ===========================================
   + Hits          4636     4926     +290     
   - Misses       10054    10092      +38     
   - Partials       458      510      +52
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...duler/server/worker/runner/TaskScheduleThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza1NjaGVkdWxlVGhyZWFkLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...pache/dolphinscheduler/common/enums/QueryType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1F1ZXJ5VHlwZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `70% <0%> (-3.69%)` | `11 <0> (ø)` | |
   | [...lphinscheduler/server/worker/task/TaskManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phinscheduler/server/worker/task/AbstractTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0VGFzay5qYXZh) | `11.59% <0%> (-0.35%)` | `2 <0> (ø)` | |
   | [...ommon/task/sqoop/sources/SourceMysqlParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3Avc291cmNlcy9Tb3VyY2VNeXNxbFBhcmFtZXRlci5qYXZh) | `100% <100%> (ø)` | `19 <19> (?)` | |
   | [...common/task/sqoop/sources/SourceHdfsParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3Avc291cmNlcy9Tb3VyY2VIZGZzUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `3 <3> (?)` | |
   | [...ommon/task/sqoop/targets/TargetMysqlParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRNeXNxbFBhcmFtZXRlci5qYXZh) | `100% <100%> (ø)` | `19 <19> (?)` | |
   | [...common/task/sqoop/targets/TargetHiveParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRIaXZlUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `17 <17> (?)` | |
   | [...common/task/sqoop/targets/TargetHdfsParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRIZGZzUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `13 <13> (?)` | |
   | ... and [32 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=footer). Last update [9cf9ee3...f9d0af1](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590145846
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B.png' alt='B' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG) [8 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2003&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.8%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list) [0.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2003&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #2003: [New Feature] add conditions task #205

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2003: [New Feature] add conditions task #205
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2003#issuecomment-590147105
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=h1) Report
   > Merging [#2003](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/9cf9ee391a676353a3d678cb25d79890ea02da31?src=pr&el=desc) will **increase** coverage by `1.11%`.
   > The diff coverage is `72.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##               dev    #2003      +/-   ##
   ===========================================
   + Coverage     30.6%   31.72%   +1.11%     
   - Complexity    1384     1512     +128     
   ===========================================
     Files          296      313      +17     
     Lines        15148    15528     +380     
     Branches      1832     1886      +54     
   ===========================================
   + Hits          4636     4926     +290     
   - Misses       10054    10092      +38     
   - Partials       458      510      +52
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/dolphinscheduler/common/enums/QueryType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1F1ZXJ5VHlwZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `70% <0%> (-3.69%)` | `11 <0> (ø)` | |
   | [...lphinscheduler/server/worker/task/TaskManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phinscheduler/server/worker/task/AbstractTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0VGFzay5qYXZh) | `11.59% <0%> (-0.35%)` | `2 <0> (ø)` | |
   | [...ommon/task/sqoop/sources/SourceMysqlParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3Avc291cmNlcy9Tb3VyY2VNeXNxbFBhcmFtZXRlci5qYXZh) | `100% <100%> (ø)` | `19 <19> (?)` | |
   | [...common/task/sqoop/sources/SourceHdfsParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3Avc291cmNlcy9Tb3VyY2VIZGZzUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `3 <3> (?)` | |
   | [...ommon/task/sqoop/targets/TargetMysqlParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRNeXNxbFBhcmFtZXRlci5qYXZh) | `100% <100%> (ø)` | `19 <19> (?)` | |
   | [...common/task/sqoop/targets/TargetHiveParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRIaXZlUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `17 <17> (?)` | |
   | [...common/task/sqoop/targets/TargetHdfsParameter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvdGFyZ2V0cy9UYXJnZXRIZGZzUGFyYW1ldGVyLmphdmE=) | `100% <100%> (ø)` | `13 <13> (?)` | |
   | [...apache/dolphinscheduler/common/enums/TaskType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Rhc2tUeXBlLmphdmE=) | `81.81% <100%> (+0.86%)` | `2 <0> (ø)` | :arrow_down: |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=footer). Last update [9cf9ee3...bcb2b17](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services