You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2020/04/02 06:02:32 UTC

[incubator-datasketches-characterization] branch HllBoundsTesting updated: Update config and minor comment.

This is an automated email from the ASF dual-hosted git repository.

leerho pushed a commit to branch HllBoundsTesting
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-characterization.git


The following commit(s) were added to refs/heads/HllBoundsTesting by this push:
     new ff59d39  Update config and minor comment.
ff59d39 is described below

commit ff59d3953d61438503d118dbb4d52652912bcf19
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Wed Apr 1 23:02:14 2020 -0700

    Update config and minor comment.
---
 .../datasketches/characterization/hll/HllBoundsAccuracyProfile.java     | 2 +-
 src/main/resources/hll/HllBoundsAccuracyJob.conf                        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/datasketches/characterization/hll/HllBoundsAccuracyProfile.java b/src/main/java/org/apache/datasketches/characterization/hll/HllBoundsAccuracyProfile.java
index d0a4233..e945811 100644
--- a/src/main/java/org/apache/datasketches/characterization/hll/HllBoundsAccuracyProfile.java
+++ b/src/main/java/org/apache/datasketches/characterization/hll/HllBoundsAccuracyProfile.java
@@ -72,7 +72,7 @@ public class HllBoundsAccuracyProfile extends BaseBoundsAccuracyProfile {
             sketch.getUpperBound(1), sketch.getUpperBound(2), sketch.getUpperBound(3));
       }
     } else { //use longs; use HIP
-      for (int i = 0; i < qArrLen; i++) {
+      for (int i = 0; i < qArrLen; i++) { //loop through all Trials Points
         final BoundsAccuracyStats q = qArr[i];
         final long delta = (long)(q.trueValue - lastUniques);
         for (long u = 0; u < delta; u++) {
diff --git a/src/main/resources/hll/HllBoundsAccuracyJob.conf b/src/main/resources/hll/HllBoundsAccuracyJob.conf
index 6d6455d..ef9509c 100644
--- a/src/main/resources/hll/HllBoundsAccuracyJob.conf
+++ b/src/main/resources/hll/HllBoundsAccuracyJob.conf
@@ -40,7 +40,7 @@ ReadableDateFormat=yyyy/MM/dd HH:mm:ss z
 
 #Job Profile
 JobProfile=org.apache.datasketches.characterization.hll.HllBoundsAccuracyProfile
-LgK=4
+LgK=12
 HLL_direct=false #only for Theta, HLL. See javadocs.
 HLL_tgtHllType=HLL8
 HLL_useComposite=false


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org