You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vincent Tran (Code Review)" <ge...@cloudera.org> on 2018/03/20 12:22:11 UTC

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9725


Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................

IMPALA-6641: Support more separators between date and time in default
timestamp format

This change adds support to the multi-space separator and the
'T' separator between the date and time component of a datetime
string during a cast (x as timestamp).

Testing:
Added valid and invalid tests to expr-test.cc to validate
the functionality during a cast.

Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-parse-util.cc
2 files changed, 33 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/9725/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................

IMPALA-6641: Support more separators between date and time in default
timestamp format

This change adds support to the multi-space separator and the
'T' separator between the date and time component of a datetime
string during a cast (x as timestamp).

Testing:
Added valid and invalid tests to expr-test.cc to validate
the functionality during a cast.

Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Reviewed-on: http://gerrit.cloudera.org:8080/9725
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-parse-util.cc
2 files changed, 53 insertions(+), 16 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 5
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9725/1/be/src/runtime/timestamp-parse-util.cc
File be/src/runtime/timestamp-parse-util.cc:

http://gerrit.cloudera.org:8080/#/c/9725/1/be/src/runtime/timestamp-parse-util.cc@407
PS1, Line 407:     if (str[4] == '-' && str[7] == '-' && str[13] == ':') {
Checking str[13] here doesn't seem right - that will read past the end of the buffer for time-only and date-only formats like "1999-10-10". I think we only want to check it for the date-time cases, not the DEFAULT_DATE_CTX case.



-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 22:37:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2173/


-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 16:05:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9725/1/be/src/runtime/timestamp-parse-util.cc
File be/src/runtime/timestamp-parse-util.cc:

http://gerrit.cloudera.org:8080/#/c/9725/1/be/src/runtime/timestamp-parse-util.cc@407
PS1, Line 407:     if (str[4] == '-' && str[7] == '-' && str[13] == ':') {
> Checking str[13] here doesn't seem right - that will read past the end of t
Good point.



-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 09:47:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 3
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 16:05:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc
File be/src/runtime/timestamp-parse-util.cc:

http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc@422
PS2, Line 422:             break;
> Break needs to go outside if, otherwise we'll fall through to the next case
Done


http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc@435
PS2, Line 435:             break;
> Same here.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 2
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 23:41:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 1:

There is a test failure. Please expect a second patch set.


-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 08:20:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 2:

(2 comments)

LGTM once these two things are fixed.

http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc
File be/src/runtime/timestamp-parse-util.cc:

http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc@422
PS2, Line 422:             break;
Break needs to go outside if, otherwise we'll fall through to the next case when str[13] is != ":".


http://gerrit.cloudera.org:8080/#/c/9725/2/be/src/runtime/timestamp-parse-util.cc@435
PS2, Line 435:             break;
Same here.



-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 2
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 15:20:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 19:49:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9725

to look at the new patch set (#2).

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................

IMPALA-6641: Support more separators between date and time in default
timestamp format

This change adds support to the multi-space separator and the
'T' separator between the date and time component of a datetime
string during a cast (x as timestamp).

Testing:
Added valid and invalid tests to expr-test.cc to validate
the functionality during a cast.

Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-parse-util.cc
2 files changed, 55 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/9725/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 2
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 1:

Missed an invalid cast that is now valid at expr-test.cc L3076.
Rerunning parameterized job now.


-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 09:11:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9725

to look at the new patch set (#3).

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................

IMPALA-6641: Support more separators between date and time in default
timestamp format

This change adds support to the multi-space separator and the
'T' separator between the date and time component of a datetime
string during a cast (x as timestamp).

Testing:
Added valid and invalid tests to expr-test.cc to validate
the functionality during a cast.

Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-parse-util.cc
2 files changed, 53 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/9725/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 3
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 )

Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ce3ba09256b3996170e42d42d49d12776cab97
Gerrit-Change-Number: 9725
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 16:05:32 +0000
Gerrit-HasComments: No