You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "azexcy (via GitHub)" <gi...@apache.org> on 2024/03/18 11:53:41 UTC

[PR] Add MariaDB E2E [shardingsphere]

azexcy opened a new pull request, #30535:
URL: https://github.com/apache/shardingsphere/pull/30535

   
   Changes proposed in this pull request:
     - Add MariaDB config files
     - Add MariaDB github action
     - Code compatible
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add MariaDB Migration E2E [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #30535:
URL: https://github.com/apache/shardingsphere/pull/30535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add MariaDB Migration E2E [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on code in PR #30535:
URL: https://github.com/apache/shardingsphere/pull/30535#discussion_r1529672310


##########
test/e2e/operation/pipeline/src/test/resources/env/it-env.properties:
##########
@@ -25,8 +25,11 @@ pipeline.it.docker.opengauss.version=
 # pipeline.it.native.database=mysql or postgresql or opengauss
 pipeline.it.native.database=
 pipeline.it.native.mysql.username=root
-pipeline.it.native.mysql.password=Root@123
+pipeline.it.native.mysql.password=root
 pipeline.it.native.mysql.port=3306
+pipeline.it.native.mariadb.username=root
+pipeline.it.native.mariadb.password=root
+pipeline.it.native.mariadb.port=3306

Review Comment:
   1, MySQL password should be recovered
   
   2, MariaDB password could use similar password



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org