You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/08/17 03:56:02 UTC

[GitHub] spark pull request #22124: [SPARK-25135][SQL] Insert datasource table may al...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22124#discussion_r210799343
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ---
    @@ -490,7 +490,8 @@ object DDLPreprocessingUtils {
           case (expected, actual) =>
             if (expected.dataType.sameType(actual.dataType) &&
               expected.name == actual.name &&
    -          expected.metadata == actual.metadata) {
    +          expected.metadata == actual.metadata &&
    +          expected.exprId.id == actual.exprId.id) {
    --- End diff --
    
    why does this fix the problem?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org