[GitHub] [incubator-pinot] snleee commented on a change in pull request #4234: Remove kafka dependency from PartitionFunction

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #4234: Remove kafka dependency from PartitionFunction
URL: https://github.com/apache/incubator-pinot/pull/4234#discussion_r286731499
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/partition/MurmurPartitionFunction.java
 ##########
 @@ -19,19 +19,11 @@
 package org.apache.pinot.core.data.partition;
 
 import com.google.common.base.Preconditions;
-import org.apache.kafka.common.utils.Utils;
 import org.apache.pinot.common.utils.StringUtil;
 
 
 /**
- * Implementation of {@link PartitionFunction} that mimics Kafka's
- * {@link org.apache.kafka.clients.producer.internals.DefaultPartitioner}.
- *
- * **** ALERT ****
- * However, this is not general purpose. It assumes that the partition key
- * was a string as used by the Tracking Producer. This is only a reference
- * implementation and users should create their own for their specific partitioner.
- *
+ * Implementation of {@link PartitionFunction} which partitions based on 32 bit murmur hash
 
 Review comment:
   Can you add the comment that this is taken from Kafka's util?
   
   Also, have you check some examples to make sure they are the same?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org