You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xingsuo-zbz (via GitHub)" <gi...@apache.org> on 2024/09/25 12:43:13 UTC
[PR] [FLINK-36344][runtime/metrics] Introduce lastCheckpointCompletedTimes… [flink]
xingsuo-zbz opened a new pull request, #25399:
URL: https://github.com/apache/flink/pull/25399
## What is the purpose of the change
Introduce the lastCheckpointCompletedTimestamp metric
## Brief change log
Register LatestCompletedCheckpointTimestampGauge named "lastCheckpointCompletedTimestamp" to CheckpointStatsTracker
## Verifying this change
This change is already covered by existing tests, such as CheckpointStatsTrackerTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36344][runtime/metrics] Introduce lastCheckpointCompletedTimestamp metric [flink]
Posted by "Myasuka (via GitHub)" <gi...@apache.org>.
Myasuka commented on PR #25399:
URL: https://github.com/apache/flink/pull/25399#issuecomment-2375646639
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36344][runtime/metrics] Introduce lastCheckpointCompletedTimestamp metric [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25399:
URL: https://github.com/apache/flink/pull/25399#issuecomment-2374133191
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "057d1079798fa8afe656740ec85af3b72dd25e8b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "057d1079798fa8afe656740ec85af3b72dd25e8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 057d1079798fa8afe656740ec85af3b72dd25e8b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36344][runtime/metrics] Introduce lastCheckpointCompletedTimestamp metric [flink]
Posted by "Myasuka (via GitHub)" <gi...@apache.org>.
Myasuka commented on code in PR #25399:
URL: https://github.com/apache/flink/pull/25399#discussion_r1778080608
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTracker.java:
##########
@@ -434,6 +434,9 @@ private void setDurationSpanAttribute(
@VisibleForTesting
static final String LATEST_COMPLETED_CHECKPOINT_ID_METRIC = "lastCompletedCheckpointId";
+ @VisibleForTesting
+ static final String LATEST_COMPLETED_CHECKPOINT_TIMESTAMP = "lastCheckpointCompletedTimestamp";
Review Comment:
I think we should rename to `LATEST_CHECKPOINT_COMPLETED_TIMESTAMP`
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTracker.java:
##########
@@ -590,4 +596,16 @@ public Long getValue() {
}
}
}
+
+ private class LatestCompletedCheckpointTimestampGauge implements Gauge<Long> {
Review Comment:
I think we should rename to `LatestCheckpointCompletedTimestampGauge`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36344][runtime/metrics] Introduce lastCheckpointCompletedTimestamp metric [flink]
Posted by "Myasuka (via GitHub)" <gi...@apache.org>.
Myasuka commented on PR #25399:
URL: https://github.com/apache/flink/pull/25399#issuecomment-2374061603
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org