You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/05/27 22:03:39 UTC
[GitHub] [couchdb-helm] colearendt opened a new pull request, #79: Create resources for GitHub release backfill
colearendt opened a new pull request, #79:
URL: https://github.com/apache/couchdb-helm/pull/79
#### What this PR does / why we need it:
Create the scripts and tooling to support creating GitHub releases with the appropriate chart data, as discussed in #62 . I tested this on my fork (you can see the releases there). It does nothing on its own, and does not help create the index.yaml or the repo proper. However, it does enable creating the backfill of GitHub Releases to build an index.yaml with later.
This branch is not very appropriately named. I will follow up with a PR that adds the CI elements to maintain this going forwards. This PR is only for backfill and should not close #62.
#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*
- fixes #
#### Special notes for your reviewer:
#### Checklist
(removed because this does not change chart data)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #79: Create resources for GitHub release backfill
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #79:
URL: https://github.com/apache/couchdb-helm/pull/79#issuecomment-1159445734
Ahh unfortunate. Good catch! Apparently my response to this never got posted haha. My search turned up empty too 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #79: Create resources for GitHub release backfill
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #79:
URL: https://github.com/apache/couchdb-helm/pull/79#issuecomment-1274179127
Nice!! Well done - sorry for missing that! I agree that time stamp preservation would be preferable. I will take a look!
As for release notes, there is a release-notes-file arg to the chart-releaser binary. Is that something you would want to maintain directly, or parse it from a NEWS file or something? And just for go forward releases, or is there something you want to use for the backfill?
On Jun 17, 2022, at 9:07 AM, Will Holley ***@***.***> wrote:

@colearendt<https://github.com/colearendt> I backfilled the releases - thanks for the scripts. However, in doing so we lose the timestamp history for the releases, which I'd like to maintain (particularly in the index yaml). I think this is fixable by setting GIT_COMMITTER_DATE before we create the release tags but I'll need to delete and recreate the releases.
I also wonder whether we can generate more useful release notes / change logs for each release but perhaps that's a distinct PR.
—
Reply to this email directly, view it on GitHub<https://github.com/apache/couchdb-helm/pull/79#issuecomment-1158853496>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFQBVVV2GGPGNFJQFKQT26TVPR2BFANCNFSM5XFSHEDQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #79: Create resources for GitHub release backfill
Posted by GitBox <gi...@apache.org>.
willholley commented on PR #79:
URL: https://github.com/apache/couchdb-helm/pull/79#issuecomment-1158853496
@colearendt I backfilled the releases - thanks for the scripts. However, in doing so we lose the timestamp history for the releases, which I'd like to maintain (particularly in the index yaml). I think this is fixable by setting `GIT_COMMITTER_DATE` before we create the release tags but I'll need to delete and recreate the releases.
I also wonder whether we can generate more useful release notes / change logs for each release but perhaps that's a distinct PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley merged pull request #79: Create resources for GitHub release backfill
Posted by GitBox <gi...@apache.org>.
willholley merged PR #79:
URL: https://github.com/apache/couchdb-helm/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #79: Create resources for GitHub release backfill
Posted by GitBox <gi...@apache.org>.
willholley commented on PR #79:
URL: https://github.com/apache/couchdb-helm/pull/79#issuecomment-1158933083
I fixed the date of the tags but couldn't find a way to set the release date so I think we'll have to leave it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #79: Create resources for GitHub release backfill
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #79:
URL: https://github.com/apache/couchdb-helm/pull/79#issuecomment-1159451132
It looks like the issue with the timestamp:
- in Releases is on GitHub, and haven't seen any indication there is a way to change that (although maybe the API has options, etc.)
- in the YAML file, seems to be a problem with `helm` itself (which `chart-releaser` [makes use of](https://github.com/helm/chart-releaser/blob/421d8708cc4d7b5271b18cce8036151a71780236/pkg/releaser/releaser.go#L298)): https://github.com/helm/helm/blob/657850e44b880cca43d0606ebf5a54eb75362c3f/pkg/repo/index.go#L141
I'm still [hopeful for the issue here](https://github.com/helm/chart-releaser/issues/133), but as you said, we may just need to sit on what we have for now 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org