[GitHub] [dubbo-go] zouyx commented on a change in pull request #1470: feat(*): add graceful shutdown

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #1470:
URL: https://github.com/apache/dubbo-go/pull/1470#discussion_r713556278



##########
File path: config/graceful_shutdown.go
##########
@@ -120,68 +111,56 @@ func destroyAllRegistries() {
 	registryProtocol.Destroy()
 }
 
-func destroyConsumerProtocols(consumerProtocols *gxset.HashSet) {
-	logger.Info("Graceful shutdown --- Destroy consumer's protocols. ")
+// destroyProtocols destroys protocols.
+// First we destroy provider's protocols, and then we destroy the consumer protocols.
+func destroyProtocols() {
+	logger.Info("Graceful shutdown --- Destroy protocols. ")
+	logger.Info("Graceful shutdown --- First destroy provider's protocols. ")

Review comment:
       What about combine this two logs？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org