You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rok (via GitHub)" <gi...@apache.org> on 2023/04/15 15:50:31 UTC
[GitHub] [arrow] rok opened a new pull request, #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
rok opened a new pull request, #35154:
URL: https://github.com/apache/arrow/pull/35154
### Rationale for this change
`std::reinterpret_pointer_cast` was introduced with FixedShapeTensor PR (#34797) but is not available on OSX (see #35143).
### What changes are included in this PR?
This change switches to using `internal::checked_pointer_cast`.
### Are these changes tested?
Change is tested in CI, but should also be verified on crossbow.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1510495765
@github-actions crossbow submit verify-rc-source-cpp-macos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1510514528
Revision: 75a091fbd918758cb561ccb3c5cc3efcac5515de
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f9fd62314b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f9fd62314b)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4715859100/jobs/8363113390)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1513954513
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5cf4da1bb9864f3fa0fb9d7550b79503...3690dddafea0472ca58cc1cab8ac5001/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1509876247
* Closes: #35143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1510539072
@paleolimbot mac builds now pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1513953631
Benchmark runs are scheduled for baseline = 94b34233b17539a6d2a3808c2d5836ef6d3153ea and contender = 5605cf5ddfeed71becef5d0020c1288eff2d98bc. 5605cf5ddfeed71becef5d0020c1288eff2d98bc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c079012c476249068ac1915940054fce...8cd319b8259a44b69d276a8eb02d6e56/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b1951a19dc794e9cb69bd4d3bf6caf41...aa3a842988df4f54a3e6d066a4b38cee/)
[Finished :arrow_down:1.02% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5cf4da1bb9864f3fa0fb9d7550b79503...3690dddafea0472ca58cc1cab8ac5001/)
[Finished :arrow_down:0.52% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/39c93aa23aa74840958d7804ef3b7a6d...6c940dce0875457297989f4d8a103021/)
Buildkite builds:
[Finished] [`5605cf5d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2732)
[Failed] [`5605cf5d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2766)
[Finished] [`5605cf5d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2730)
[Finished] [`5605cf5d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2757)
[Finished] [`94b34233` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2731)
[Failed] [`94b34233` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2765)
[Finished] [`94b34233` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2729)
[Finished] [`94b34233` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2756)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1510496170
Revision: 75a091fbd918758cb561ccb3c5cc3efcac5515de
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2d2b1993f0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2d2b1993f0)
|Task|Status|
|----|------|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4715515360/jobs/8362554122)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4715515114/jobs/8362553805)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4715515281/jobs/8362553996)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1510519333
Revision: 75a091fbd918758cb561ccb3c5cc3efcac5515de
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c5fa4612d6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c5fa4612d6)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4715959161/jobs/8363266934)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1510513958
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1510518724
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot merged pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #35154:
URL: https://github.com/apache/arrow/pull/35154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35154: GH-35143: [R][C++] Fixed shape tensor causes broken build on OSX
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35154:
URL: https://github.com/apache/arrow/pull/35154#issuecomment-1509876256
:warning: GitHub issue #35143 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org