You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/01 15:36:50 UTC
[GitHub] [netbeans] lbruun opened a new pull request #1835: [NETBEANS-3652]
PAC: myIpAddress() returns "127.0.0.1" when executed in Travis env
lbruun opened a new pull request #1835: [NETBEANS-3652] PAC: myIpAddress() returns "127.0.0.1" when executed in Travis env
URL: https://github.com/apache/netbeans/pull/1835
Currently, tests fails because the `LocalAddressUtils.getMostLikelyLocalInetAddresses()` - when executed by Travis - returns "127.0.0.1" which means the code was not able to determine the local host's IP.
This PR fixes this problem by improving local IP address discovery:
An additional method is added to the multiple ways of finding own host's IP: **UDP Socket**. In some environments (e.g. Travis) this addition will be able to find the IP where the other methods fail. However, discovering the IP of the local host remains an imprecise discipline.
Also, the `getMostLikelyLocalInetAddresses()` method is now more precise about filtering out loopback addresses potentially returned by one of the underlying methods. Returning the loopback address from this method should really, really be a last resort.
Test of the `core.network` module is re-instated in `.travis.yml` because with this change the test no longer fails when executed in Travis env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1835:
[NETBEANS-3652] PAC: myIpAddress() returns "127.0.0.1" when executed in
Travis env
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1835: [NETBEANS-3652] PAC: myIpAddress() returns "127.0.0.1" when executed in Travis env
URL: https://github.com/apache/netbeans/pull/1835#issuecomment-570657241
@blackleg @lbruun thank you both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #1835:
[NETBEANS-3652] PAC: myIpAddress() returns "127.0.0.1" when executed in
Travis env
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #1835: [NETBEANS-3652] PAC: myIpAddress() returns "127.0.0.1" when executed in Travis env
URL: https://github.com/apache/netbeans/pull/1835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists