You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/18 08:25:05 UTC
[GitHub] [flink] rmetzger opened a new pull request, #21344: [FLINK-30083] Bump maven-shade-plugin version
rmetzger opened a new pull request, #21344:
URL: https://github.com/apache/flink/pull/21344
## What is the purpose of the change
[FLINK-24273](https://issues.apache.org/jira/browse/FLINK-24273) proposes to relocate the io.fabric8 dependencies of flink-kubernetes.
This is not possible because of a problem with the maven shade plugin ("mvn install" doesn't work, it needs to be "mvn clean install").
[MSHADE-425](https://issues.apache.org/jira/browse/MSHADE-425) solves this issue, and has been released with maven-shade-plugin 3.4.0.
Upgrading the shade plugin will solve the problem, unblocking the K8s relocation.
## Brief change log
- bump the version.
## Verifying this change
Covered by CI
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
rmetzger commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1326489950
Thanks a lot for the careful review! I addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a diff in pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
rmetzger commented on code in PR #21344:
URL: https://github.com/apache/flink/pull/21344#discussion_r1031550455
##########
pom.xml:
##########
@@ -991,7 +991,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.4</version>
+ <version>3.4.0</version>
Review Comment:
a) no real reason. I thought it would be safer to update to the minimum required version.... but using the latest bugfix version should actually be even safer.
b) I didn't check the surroundings enough. Just looked for maven-shade-plugin and changed the version 🙈
Great that this fixes more issues. Let's hope it works (my previous change was a no-op for our CI I guess ;) ) and it doesn't introduce other issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1329058463
Alternatively we could consider disabling dependency reduction once #21349 is in, because at that point it should be no longer _required_ (but the reduced poms would still be nicer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21344:
URL: https://github.com/apache/flink/pull/21344#discussion_r1026171420
##########
pom.xml:
##########
@@ -991,7 +991,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.4</version>
+ <version>3.4.0</version>
Review Comment:
a) Why not 3.4.1?
b) Why make this specific to Java 11? We should try upgrading it in the default configuration and (I guess) get rid of the java11-specific configuration
FYI, 3.4.1 also fixes FLINK-20092 from some brief testing another person did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1326683572
What the...
```
3 Unknown Licenses
*****************************************************
Files with unapproved licenses:
/__w/1/s/target/checkstyle-result.xml
/__w/1/s/target/rat.txt
/__w/1/s/target/checkstyle-cachefile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1326708204
The rat plugin already has an exclusion for `**/target/**` though. Changing it to `target/**` had no effect, but explicitly listing `**/rat.txt` did.
Still, I'd like to know what is going on here before changing anything.
I'll file a ticket; maybe the shade folks have some idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1329045555
Just FYI the checkstyle plugin is now also failing.
When dependency reduction is applied the shade-plugin changes the project basedir to the directory into which the dependency-reduced pom is written to, in our case `target/`. This now also happens for modules with the `pom` packaging, breaking relative paths in some plugin configurations, like the suppression files for checkstyle. :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol merged PR #21344:
URL: https://github.com/apache/flink/pull/21344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1329050843
We can fix the rat issue by just running it in the validate phase; but not sure yet what to do about checkstyle Suppressions could be moved into each module, but what about the config file? We could consider moving it into a separate module/project and [loading the rules from the classpath](https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html). This could also be useful for the connector projects since we'd be able to share the rule set easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1346464128
Update: We'll merge this after #21477.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21344:
URL: https://github.com/apache/flink/pull/21344#discussion_r1026171420
##########
pom.xml:
##########
@@ -991,7 +991,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.4</version>
+ <version>3.4.0</version>
Review Comment:
a) Why not 3.4.1?
b) Why make this specific to Java 11? We should try upgrading it in the default configuration (since you're trying to fix a general build issue) and (I guess) get rid of the java11-specific configuration (since it's subsumed).
FYI, 3.4.1 also fixes FLINK-20092 from some brief testing another person did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1326686909
Wow this even happens locally. `mvn clean verify -N`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jnh5y commented on a diff in pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
jnh5y commented on code in PR #21344:
URL: https://github.com/apache/flink/pull/21344#discussion_r1028404398
##########
pom.xml:
##########
@@ -991,7 +991,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.4</version>
+ <version>3.4.0</version>
Review Comment:
@rmetzger I'm the random person that @zentol mentioned!
I was about to open a PR to bump this version to 3.4.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1319695253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ed51cdd91d0eae337f54745b8470af111145bba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3ed51cdd91d0eae337f54745b8470af111145bba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ed51cdd91d0eae337f54745b8470af111145bba UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1319721135
FYI, we already have a relocation for io.fabric8: https://github.com/apache/flink/blob/master/flink-kubernetes/pom.xml#L171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
rmetzger commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1326693114
I’m also confused. Updating rat doesn’t help.
On Thu 24. Nov 2022 at 18:01 Chesnay Schepler ***@***.***>
wrote:
> Wow this even happens locally. mvn clean verify -N
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/flink/pull/21344#issuecomment-1326686909>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAVXWJCPZ5XVHJTJINS45LWJ6NQDANCNFSM6AAAAAASEHKRSM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
Robert Metzger, Kontakt: ***@***.***, Mobil: 0171/7424461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1326700020
This seems to happen with every version since 3.3.0.
For some reason the files in the root target directory are now included by the rat plugin. (-X shows the included/excluded files).
@jnh5y This is a good example of why I'm so hesitant about plugin upgrades :weary:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jnh5y commented on pull request #21344: [FLINK-30083] Bump maven-shade-plugin version
Posted by GitBox <gi...@apache.org>.
jnh5y commented on PR #21344:
URL: https://github.com/apache/flink/pull/21344#issuecomment-1326704652
> This seems to happen with every version since 3.3.0.
>
> For some reason the files in the root target directory are now included by the rat plugin. (-X shows the included/excluded files).
>
> @jnh5y This is a good example of why I'm so hesitant about plugin upgrades 😩
Wow... that's a really, really strange thing for a Maven Shade plugin change to impact... Looks like some rat configuration may need to be updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org