You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/04 20:52:09 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3000:
ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
clebertsuconic opened a new pull request #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
URL: https://github.com/apache/activemq-artemis/pull/3000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with
ServerLocator
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
URL: https://github.com/apache/activemq-artemis/pull/3000#discussion_r387927367
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java
##########
@@ -19,7 +19,7 @@
import java.util.concurrent.Executor;
import java.util.concurrent.ScheduledExecutorService;
-import org.apache.activemq.artemis.api.config.ServerLocatorConfig;
+import org.apache.activemq.artemis.api.core.client.loadbalance.ServerLocatorConfig;
Review comment:
oops.. that's not where I meant it to be..
Glad I'm doing my own review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #3000:
ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
URL: https://github.com/apache/activemq-artemis/pull/3000#issuecomment-600221810
@michaelandrepearce this is a new class, recently introduced. Howard introduced it to externalize the configuration as part of ARTEMIS-2716
this is tightly coupled with ServerLocator, and I consider the API to be cleaner if they live together in the same package.
Right now there's a single class in config for Default configuration. I didn't think it would fit in there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with
ServerLocator
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
URL: https://github.com/apache/activemq-artemis/pull/3000#discussion_r387928114
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java
##########
@@ -19,7 +19,7 @@
import java.util.concurrent.Executor;
import java.util.concurrent.ScheduledExecutorService;
-import org.apache.activemq.artemis.api.config.ServerLocatorConfig;
+import org.apache.activemq.artemis.api.core.client.loadbalance.ServerLocatorConfig;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3000:
ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
URL: https://github.com/apache/activemq-artemis/pull/3000#issuecomment-596136958
what's the reason we are moving a config file out of the config package? isn't the idea all config classes live in config packaged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic closed pull request #3000:
ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #3000: ARTEMIS-2716 Moving ServerLocatorConfig together with ServerLocator
URL: https://github.com/apache/activemq-artemis/pull/3000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services