You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Filippo Munafò (JIRA)" <xa...@xml.apache.org> on 2005/09/23 00:58:28 UTC
[jira] Created: (XALANJ-2204) Function Count on variable modifies number of nodes in variable.
Function Count on variable modifies number of nodes in variable.
----------------------------------------------------------------
Key: XALANJ-2204
URL: http://issues.apache.org/jira/browse/XALANJ-2204
Project: XalanJ2
Type: Bug
Components: transformation
Versions: 2.7
Reporter: Filippo Munafò
Priority: Blocker
Transforming this XML:
<A>
<B>1</B>
<B>2</B>
</A>
with the following XSL:
<xsl:variable name="XML" select="/A"/>
<xsl:template match="/">
First:
<xsl:value-of select="count($XML[B=1])"/>
Second:
<xsl:value-of select="count($XML[B=1])"/>
Third:
<xsl:value-of select="count($XML[B=1])"/>
</xsl:template>
the output is:
First:
1
Second:
2
Third:
3
instead of:
First:
1
Second:
1
Third:
1
Using XALAN 2.6 everithing works as it should be.
Using:
xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
instead of:
transformer.transform(xml, xsl)
the result is the right one!
Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=all ]
Brian Minchau resolved XALANJ-2204.
-----------------------------------
Fix Version/s: Latest Development Code
Resolution: Fixed
I just applied patch4, which was recently reviewed by Henry Zongaro (thanks Henry).
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assigned To: Brian Minchau
> Priority: Blocker
> Fix For: Latest Development Code
>
> Attachments: jira_2204.patch2.txt, jira_2204.patch3.txt, jira_2204.patch4.txt, patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2204) Function Count on variable modifies number of nodes in variable.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=all ]
Brian Minchau reassigned XALANJ-2204:
-------------------------------------
Assign To: Joanne Tong
Assigning to Joanne Tong, per the JIRA meeting on Nov 1, 2005
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Type: Bug
> Components: transformation
> Versions: 2.7
> Reporter: Filippo Munafò
> Assignee: Joanne Tong
> Priority: Blocker
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Henry Zongaro (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=comments#action_12445714 ]
Henry Zongaro commented on XALANJ-2204:
---------------------------------------
One comment on Brian's patch4, it would be nice if the use count in IteratorCache could somehow be decremented when references to the IteratorCache go away, but I believe the patch is correct as it stands.
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assigned To: Brian Minchau
> Priority: Blocker
> Attachments: jira_2204.patch2.txt, jira_2204.patch3.txt, jira_2204.patch4.txt, patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Ilene Seelemann (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=comments#action_12365461 ]
Ilene Seelemann commented on XALANJ-2204:
-----------------------------------------
I've reviewed this patch and it looks good. Note that this regression was introduced by the patch for XalanJ-1810. There seems to be some brittleness in the code around the resetting of iterator's when cloning.
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Type: Bug
> Components: transformation
> Versions: 2.7
> Reporter: Filippo Munafò
> Assignee: Joanne Tong
> Priority: Blocker
> Attachments: patch_jira_2204.txt
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=comments#action_12445392 ]
Brian Minchau commented on XALANJ-2204:
---------------------------------------
I can confirm that patch4 did not cause any regressions in:
> smoketest for Xalan-J interpretive
> smoketest for XSLTC
> conformance tests for Xalan-J interpretive (all flavors)
> conformance tests for XSLTC (all flavors)
> acceptance tests for Xalan-J interpretive (all flavors)
> acceptance tests for XSLTC (all flavors)
That should ease the stress on the patch reviewer.
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assigned To: Brian Minchau
> Priority: Blocker
> Attachments: jira_2204.patch2.txt, jira_2204.patch3.txt, jira_2204.patch4.txt, patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Filippo Munafò (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550909 ]
Filippo Munafò commented on XALANJ-2204:
----------------------------------------
I've just verified that it's fixed in release 2.7.1.
The issue can be closed.
Thanks,
Filippo Munafò
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: https://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assignee: Brian Minchau
> Priority: Blocker
> Fix For: 2.7.1
>
> Attachments: jira_2204.patch2.txt, jira_2204.patch3.txt, jira_2204.patch4.txt, patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=comments#action_12443421 ]
Brian Minchau commented on XALANJ-2204:
---------------------------------------
patch2 does not break any of the conformance tests (all flavors).
In addition I tested it with the testcases of all issues related to this one.
column (A) - original pass/fail results
column (B) - pass/fail results when the original patch for this issue is reversed.
column (C) - pass/fail results for when patch2 is applied, which removes the original patch
but a;sp provides an alternate patch.
(A) (B) (C)
XALANJ-2204 P F P
XALANJ-2285 F P P
XALANJ-2293 P F P
XALANJ-2324 F P P
So we see that the original patch in this issue exactly flips the results (column (A) and (B) ), and this patch
gets all them all to pass, and hopefully for the right reason.
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assigned To: Brian Minchau
> Priority: Blocker
> Attachments: jira_2204.patch2.txt, patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Henry Zongaro (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=comments#action_12445713 ]
Henry Zongaro commented on XALANJ-2204:
---------------------------------------
I have reviewed Brian's patch4 [1] and believe that it correctly resolves this defect as well as related and duplicate defects.
[1] http://issues.apache.org/jira/secure/attachment/12343808/jira_2204.patch4.txt
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assigned To: Brian Minchau
> Priority: Blocker
> Attachments: jira_2204.patch2.txt, jira_2204.patch3.txt, jira_2204.patch4.txt, patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Closed: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Filippo Munafò (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filippo Munafò closed XALANJ-2204.
----------------------------------
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: https://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assignee: Brian Minchau
> Priority: Blocker
> Fix For: 2.7.1
>
> Attachments: jira_2204.patch2.txt, jira_2204.patch3.txt, jira_2204.patch4.txt, patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2204) Function Count on variable modifies
number of nodes in variable.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2204?page=all ]
Brian Minchau reassigned XALANJ-2204:
-------------------------------------
Assignee: Brian Minchau (was: Joanne Tong)
Assigning this issue to Brian Minchau.
The patch provided by Joanne may have resolved the problem in this issue,
but it caused regressions for XALANJ-2324 and XALANJ-2286, both of which
will be fixed when this patch is undone.
However then this issue must have another fix.
I'll be posting a fix shortly that I've been working on.
> Function Count on variable modifies number of nodes in variable.
> ----------------------------------------------------------------
>
> Key: XALANJ-2204
> URL: http://issues.apache.org/jira/browse/XALANJ-2204
> Project: XalanJ2
> Issue Type: Bug
> Components: transformation
> Affects Versions: 2.7
> Reporter: Filippo Munafò
> Assigned To: Brian Minchau
> Priority: Blocker
> Attachments: patch_jira_2204.txt
>
>
> Transforming this XML:
> <A>
> <B>1</B>
> <B>2</B>
> </A>
> with the following XSL:
> <xsl:variable name="XML" select="/A"/>
>
> <xsl:template match="/">
> First:
> <xsl:value-of select="count($XML[B=1])"/>
> Second:
> <xsl:value-of select="count($XML[B=1])"/>
> Third:
> <xsl:value-of select="count($XML[B=1])"/>
> </xsl:template>
> the output is:
> First:
> 1
> Second:
> 2
> Third:
> 3
> instead of:
> First:
> 1
> Second:
> 1
> Third:
> 1
> Using XALAN 2.6 everithing works as it should be.
> Using:
> xalan.jar org.apache.xalan.xslt.Process -in %1 -xsl %2 -out %3
> instead of:
> transformer.transform(xml, xsl)
> the result is the right one!
> Filippo
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org