[jira] [Commented] (CLIMATE-597) Subsetting a dataset should update the names attribute

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLIMATE-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363809#comment-14363809 ] 

ASF GitHub Bot commented on CLIMATE-597:
----------------------------------------

Github user MJJoyce commented on the pull request:

    https://github.com/apache/climate/pull/170#issuecomment-81908466
  
    @kwhitehall Regarding the safe_subset function, it lacks the ability to use this added optional name argument. That seems like something worth having in my opinion. My recommendation wasn't to update the docs or anything on that, it was to add the same functionality for it under this ticket since they're so related.
    
    Also, it looks like you got a few merge commits and stuff in there. A `git rebase -i master` and squashing those follow up commits would clean things up nicely!


> Subsetting a dataset should update the names attribute
> ------------------------------------------------------
>
>                 Key: CLIMATE-597
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-597
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>            Reporter: Kim Whitehall
>            Assignee: Kim Whitehall
>            Priority: Minor
>
> Currently when a dataset is subsetted, the name of the new dataset doesn't change. This may cause issues later for identifying subsets for e.g. in plotter.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)