You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/03 09:02:54 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #10028: Replace BrokerStates.scala with BrokerState.java

ijuma commented on a change in pull request #10028:
URL: https://github.com/apache/kafka/pull/10028#discussion_r569239693



##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -60,7 +61,7 @@ class LogManager(logDirs: Seq[File],
                  val retentionCheckMs: Long,
                  val maxPidExpirationMs: Int,
                  scheduler: Scheduler,
-                 val brokerState: BrokerState,
+                 val brokerState: AtomicReference[BrokerState],

Review comment:
       Is there a reason why you're using an AtomicReference instead of a volatile var?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org