You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/30 13:41:27 UTC
[GitHub] [incubator-seatunnel] v-wx-v opened a new pull request, #1975: [fix bug] When use TiDB, Spark JDBC update mode, Error "The isolation level ‘READ-UNCOMMITTED’ is not supported. Set tidb_skip_isolation_level_check=1 to skip this error"
v-wx-v opened a new pull request, #1975:
URL: https://github.com/apache/incubator-seatunnel/pull/1975
…n level ‘READ-UNCOMMITTED’ is not supported. Set tidb_skip_isolation_level_check=1 to skip this erro
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] v-wx-v commented on a diff in pull request #1975: [fix bug] When use TiDB, Spark JDBC update mode, Error "The isolation level ‘READ-UNCOMMITTED’ is not supported. Set tidb_skip_isolation_level_check=1 to skip this error"
Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #1975:
URL: https://github.com/apache/incubator-seatunnel/pull/1975#discussion_r885461562
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-jdbc/src/main/scala/org/apache/seatunnel/spark/jdbc/sink/Jdbc.scala:
##########
@@ -65,6 +66,7 @@ class Jdbc extends SparkBatchSink {
"saveMode" -> "error",
"useSsl" -> "false",
"showSql" -> "true",
+ "isolationLevel" -> "READ_UNCOMMITTED",
Review Comment:
OK. I will add this config to document soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan merged pull request #1975: [fix bug] When use TiDB, Spark JDBC update mode, Error "The isolation level ‘READ-UNCOMMITTED’ is not supported. Set tidb_skip_isolation_level_check=1 to skip this error"
Posted by GitBox <gi...@apache.org>.
BenJFan merged PR #1975:
URL: https://github.com/apache/incubator-seatunnel/pull/1975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1975: [fix bug] When use TiDB, Spark JDBC update mode, Error "The isolation level ‘READ-UNCOMMITTED’ is not supported. Set tidb_skip_isolation_level_check=1 to skip this error"
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1975:
URL: https://github.com/apache/incubator-seatunnel/pull/1975#discussion_r885143769
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-jdbc/src/main/scala/org/apache/seatunnel/spark/jdbc/sink/Jdbc.scala:
##########
@@ -65,6 +66,7 @@ class Jdbc extends SparkBatchSink {
"saveMode" -> "error",
"useSsl" -> "false",
"showSql" -> "true",
+ "isolationLevel" -> "READ_UNCOMMITTED",
Review Comment:
I think the default value should be `READ_COMMITTED`, and please add this config to document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] v-wx-v commented on a diff in pull request #1975: [fix bug] When use TiDB, Spark JDBC update mode, Error "The isolation level ‘READ-UNCOMMITTED’ is not supported. Set tidb_skip_isolation_level_check=1 to skip this error"
Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #1975:
URL: https://github.com/apache/incubator-seatunnel/pull/1975#discussion_r885459294
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-jdbc/src/main/scala/org/apache/seatunnel/spark/jdbc/sink/Jdbc.scala:
##########
@@ -65,6 +66,7 @@ class Jdbc extends SparkBatchSink {
"saveMode" -> "error",
"useSsl" -> "false",
"showSql" -> "true",
+ "isolationLevel" -> "READ_UNCOMMITTED",
Review Comment:
In Spark ，the default value of isolationLevel is "READ_UNCOMMITTED". Please see https://spark.apache.org/docs/latest/sql-data-sources-jdbc.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org