[jira] [Commented] (HBASE-28452) Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-28452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832039#comment-17832039 ] 

Hudson commented on HBASE-28452:
--------------------------------

Results for branch branch-2.4
	[build #713 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/713/]: (/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/713/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/713/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/713/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/713/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-28452
>                 URL: https://issues.apache.org/jira/browse/HBASE-28452
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ConfX
>            Priority: Major
>              Labels: pull-request-available
>
> When `hbase.client.default.rpc.codec` is set to `org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec` the method `createRpcClientRTEDuringConnectionSetup` gives a NoSuchMethodException for the provided default codec value. 
>  
> Since there was an exception, the code inside try block is not executed which contained the below code line 
> {code:java}
> try (AbstractRpcClient<?> client = createRpcClientRTEDuringConnectionSetup(clientConf))
> {       rpcServer.start();       . . .     }
> {code}
>  
> When finally block is executed which contains 
> {code:java}
> finally
> {       rpcServer.stop();     }
> {code}
>  
> The method `rpcServer.stop()` eventually makes call to `executor.shutdown()`. A null pointer exception is returned as  `rpcServer.scheduler.executor`  was never instantiated, which happens inside `rpcServer.start()`
>  
> {code:java}
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.ipc.FifoRpcScheduler.stop(FifoRpcScheduler.java:71)
> at org.apache.hadoop.hbase.ipc.SimpleRpcServer.stop(SimpleRpcServer.java:441)
> at org.apache.hadoop.hbase.ipc.AbstractTestIPC.testRTEDuringConnectionSetup(AbstractTestIPC.java:194){code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)