You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/14 15:29:24 UTC
Review Request 62332: Linted JavaScript files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62332/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7978
https://issues.apache.org/jira/browse/MESOS-7978
Repository: mesos
Description
-------
In a future patch, we will enable JavaScript linting. This patch
is an update of our current JavaScript files removing the errors
that would otherwise return ESLint.
Diffs
-----
src/webui/master/static/js/app.js e11f881e947c11fd9fac717f12101726c2c6e380
src/webui/master/static/js/controllers.js 339dfc4786ef4b88b9a16a0eb41b9b72836d469b
src/webui/master/static/js/services.js afd25441813324ce54f09733fd501ebf1564ef7d
Diff: https://reviews.apache.org/r/62332/diff/1/
Testing
-------
Thanks,
Armand Grillet
Re: Review Request 62332: Linted JavaScript files.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62332/#review185740
-----------------------------------------------------------
Fix it, then Ship it!
I will commit this without the ellipsis change, can you follow up with a separate fix for that?
src/webui/master/static/js/app.js
Line 76 (original), 92 (patched)
<https://reviews.apache.org/r/62332/#comment262083>
I think the use of elipsis was intentional here, have you compared the visual look before and after this change? The no impact change here would have been to use '\u2026'?
- Benjamin Mahler
On Sept. 14, 2017, 3:29 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62332/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 3:29 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7978
> https://issues.apache.org/jira/browse/MESOS-7978
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In a future patch, we will enable JavaScript linting. This patch
> is an update of our current JavaScript files removing the errors
> that would otherwise return ESLint.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js e11f881e947c11fd9fac717f12101726c2c6e380
> src/webui/master/static/js/controllers.js 339dfc4786ef4b88b9a16a0eb41b9b72836d469b
> src/webui/master/static/js/services.js afd25441813324ce54f09733fd501ebf1564ef7d
>
>
> Diff: https://reviews.apache.org/r/62332/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62332: Linted JavaScript files.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62332/#review185626
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62332']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62332
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62332/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (283 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (242 ms)
[----------] 30 tests from ContentType/SchedulerTest (25452 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (1166 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1182 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2484 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (138 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (152 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (411 ms total)
[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (357074 ms total)
[ PASSED ] 626 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where GetParam() = application/json
1 FAILED TEST
YOU HAVE 174 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62332/logs/mesos-tests-stderr.log):
```
I0918 22:15:19.008848 17356 master.cpp:8418] Removing framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 (default)
I0918 22:15:19.008848 17356 master.cpp:3267] Deactivating framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 (default)
I0918 22:15:19.009850 21088 hierarchical.cpp:412] Deactivated framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000
I0918 22:15:19.009850 20792 slave.cpp:3235] Shutting down framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000
I0918 22:15:19.009850 17356 master.cpp:8993] Updating the state of task 17f92b4e-58ef-4881-b54b-3fefdf309a97 of framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0918 22:15:19.009850 20792 slave.cpp:5731] Shutting down executor 'default' of framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 (via HTTP)
I0918 22:15:19.013850 17356 master.cpp:9087] Removing task 17f92b4e-58ef-4881-b54b-3fefdf309a97 with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 on agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0 at slave(254)@10.3.1.5:52150 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0918 22:15:19.036852 17356 master.cpp:9116] Removing executor 'default' with resources [] of framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 on agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0 at slave(254)@10.3.1.5:52150 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0918 22:15:19.040853 15292 hierarchical.cpp:355] Removed framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000
E0918 22:15:19.040853 14848 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I0918 22:15:19.064852 14848 scheduler.cpp:444] Re-detecting master
I0918 22:15:19.066861 21256 scheduler.cpp:470] New master detected at master@10.3.1.5:52150
I0918 22:15:19.081854 15292 slave.cpp:5407] Executor 'default' of framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 exited with status 0
I0918 22:15:19.082854 15292 slave.cpp:5511] Cleaning up executor 'default' of framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 (via HTTP)
W0918 22:15:19.083854 21020 master.cpp:7021] Ignoring unknown exited executor 'default' of framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 on agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0 at slave(254)@10.3.1.5:52150 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0918 22:15:19.084854 21088 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\9lXy5v\slaves\fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0\frameworks\fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000\executors\default\runs\9c6b1f1d-ebac-4a01-ac4a-70144956855b' for gc 6.99998745538074days in the future
I0918 22:15:19.090854 15292 slave.cpp:5607] Cleaning up framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000
I0918 22:15:19.107856 14848 status_update_manager.cpp:285] Closing status update streams for framework fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000
I0918 22:15:19.107856 21088 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\9lXy5v\slaves\fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0\frameworks\fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000\executors\default' for gc 6.99998737436444days in the future
I0918 22:15:19.108857 15292 slave.cpp:861] Agent terminating
I0918 22:15:19.108857 21088 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\9lXy5v\slaves\fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0\frameworks\fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000' for gc 6.99998717758222days in the future
I0918 22:15:19.109856 20792 master.cpp:1321] Agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0 at slave(254)@10.3.1.5:52150 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0918 22:15:19.148324 20792 master.cpp:3304] Disconnecting agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0 at slave(254)@10.3.1.5:52150 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0918 22:15:19.148324 20792 master.cpp:3323] Deactivating agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0 at slave(254)@10.3.1.5:52150 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0918 22:15:19.148324 19964 hierarchical.cpp:690] Agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0 deactivated
I0918 22:15:19.148324 20792 master.cpp:1163] Master terminating
I0918 22:15:19.153070 17356 hierarchical.cpp:626] Removed agent fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-S0
W0918 22:15:19.158071 19992 master.hpp:2761] Failed to close HTTP pipe for fa8ea04d-ff42-4f9f-b5ae-27217af37bc9-0000 (default)
I0918 22:15:20.039460 17552 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Sept. 14, 2017, 3:29 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62332/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 3:29 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7978
> https://issues.apache.org/jira/browse/MESOS-7978
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In a future patch, we will enable JavaScript linting. This patch
> is an update of our current JavaScript files removing the errors
> that would otherwise return ESLint.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js e11f881e947c11fd9fac717f12101726c2c6e380
> src/webui/master/static/js/controllers.js 339dfc4786ef4b88b9a16a0eb41b9b72836d469b
> src/webui/master/static/js/services.js afd25441813324ce54f09733fd501ebf1564ef7d
>
>
> Diff: https://reviews.apache.org/r/62332/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>