You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/08/07 17:30:27 UTC

Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13377/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.


Bugs: CLOUDSTACK-4021


Repository: cloudstack-git


Description
-------

Test case "integration.component.test_explicit_dedication.TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication" fails if it does not find an empty hosts.
In case there is at least 1 empty host present, that host is dedicated and a vm is deployed using explicit dedication affinity group.
Added check that skips the test in case there are no empty hosts found.


Diffs
-----

  test/integration/component/test_explicit_dedication.py e1991ac 

Diff: https://reviews.apache.org/r/13377/diff/


Testing
-------

If there are no empty hosts present, the test returns without further dedication or deploying vms.
If there is a single empty host present, the host is dedicated and vm is deployed.


Thanks,

Saksham Srivastava


Re: Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13377/#review24871
-----------------------------------------------------------


Commit 8191f5c6902b3c0d677858ef851f1eade8871d8d in branch refs/heads/4.2 from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8191f5c ]

CLOUDSTACK-4021:[Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On Aug. 7, 2013, 4:18 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13377/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 4:18 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4021
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case "integration.component.test_explicit_dedication.TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication" fails if it does not find an empty hosts.
> In case there is at least 1 empty host present, that host is dedicated and a vm is deployed using explicit dedication affinity group.
> Added check that skips the test in case there are no empty hosts found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_explicit_dedication.py e1991ac 
> 
> Diff: https://reviews.apache.org/r/13377/diff/
> 
> 
> Testing
> -------
> 
> If there are no empty hosts present, the test returns without further dedication or deploying vms.
> If there is a single empty host present, the host is dedicated and vm is deployed.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13377/#review24873
-----------------------------------------------------------

Ship it!


- Prasanna Santhanam


On Aug. 7, 2013, 4:18 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13377/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 4:18 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4021
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case "integration.component.test_explicit_dedication.TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication" fails if it does not find an empty hosts.
> In case there is at least 1 empty host present, that host is dedicated and a vm is deployed using explicit dedication affinity group.
> Added check that skips the test in case there are no empty hosts found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_explicit_dedication.py e1991ac 
> 
> Diff: https://reviews.apache.org/r/13377/diff/
> 
> 
> Testing
> -------
> 
> If there are no empty hosts present, the test returns without further dedication or deploying vms.
> If there is a single empty host present, the host is dedicated and vm is deployed.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13377/#review24870
-----------------------------------------------------------


Commit ac6b26ff810cd2f3a9f7de0fa7bb481dd0781be3 in branch refs/heads/master from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ac6b26f ]

CLOUDSTACK-4021:[Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 8191f5c6902b3c0d677858ef851f1eade8871d8d)


- ASF Subversion and Git Services


On Aug. 7, 2013, 4:18 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13377/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 4:18 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4021
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case "integration.component.test_explicit_dedication.TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication" fails if it does not find an empty hosts.
> In case there is at least 1 empty host present, that host is dedicated and a vm is deployed using explicit dedication affinity group.
> Added check that skips the test in case there are no empty hosts found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_explicit_dedication.py e1991ac 
> 
> Diff: https://reviews.apache.org/r/13377/diff/
> 
> 
> Testing
> -------
> 
> If there are no empty hosts present, the test returns without further dedication or deploying vms.
> If there is a single empty host present, the host is dedicated and vm is deployed.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13377/#review24872
-----------------------------------------------------------

Ship it!


- Prasanna Santhanam


On Aug. 7, 2013, 4:18 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13377/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 4:18 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4021
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case "integration.component.test_explicit_dedication.TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication" fails if it does not find an empty hosts.
> In case there is at least 1 empty host present, that host is dedicated and a vm is deployed using explicit dedication affinity group.
> Added check that skips the test in case there are no empty hosts found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_explicit_dedication.py e1991ac 
> 
> Diff: https://reviews.apache.org/r/13377/diff/
> 
> 
> Testing
> -------
> 
> If there are no empty hosts present, the test returns without further dedication or deploying vms.
> If there is a single empty host present, the host is dedicated and vm is deployed.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13377/
-----------------------------------------------------------

(Updated Aug. 7, 2013, 4:18 p.m.)


Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.


Changes
-------

updated diff.


Bugs: CLOUDSTACK-4021


Repository: cloudstack-git


Description
-------

Test case "integration.component.test_explicit_dedication.TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication" fails if it does not find an empty hosts.
In case there is at least 1 empty host present, that host is dedicated and a vm is deployed using explicit dedication affinity group.
Added check that skips the test in case there are no empty hosts found.


Diffs (updated)
-----

  test/integration/component/test_explicit_dedication.py e1991ac 

Diff: https://reviews.apache.org/r/13377/diff/


Testing
-------

If there are no empty hosts present, the test returns without further dedication or deploying vms.
If there is a single empty host present, the host is dedicated and vm is deployed.


Thanks,

Saksham Srivastava