You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/11/20 02:44:09 UTC
Review Request 63943: Renamed `TaskStatusEq()` to
`TaskStatusTaskIdEq()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63943/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
Repository: mesos
Description
-------
Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.
Diffs
-----
src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
src/tests/mesos.hpp 345b883a8c629bf5bed83e9236632c277f2eb0eb
Diff: https://reviews.apache.org/r/63943/diff/1/
Testing
-------
Manually ran the test `MasterTest.MasterFailoverLongLivedExecutor` repeatedly (20 times), it succeeded.
Thanks,
Qian Zhang
Re: Review Request 63943: Renamed `TaskStatusEq()` to
`TaskStatusTaskIdEq()`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63943/#review191534
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On Nov. 19, 2017, 6:44 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63943/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2017, 6:44 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
> src/tests/mesos.hpp 345b883a8c629bf5bed83e9236632c277f2eb0eb
>
>
> Diff: https://reviews.apache.org/r/63943/diff/1/
>
>
> Testing
> -------
>
> Manually ran the test `MasterTest.MasterFailoverLongLivedExecutor` repeatedly (20 times), it succeeded.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 63943: Renamed `TaskStatusEq()` to
`TaskStatusTaskIdEq()`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63943/#review191599
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 20, 2017, 2:44 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63943/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2017, 2:44 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
> src/tests/mesos.hpp 345b883a8c629bf5bed83e9236632c277f2eb0eb
>
>
> Diff: https://reviews.apache.org/r/63943/diff/1/
>
>
> Testing
> -------
>
> Manually ran the test `MasterTest.MasterFailoverLongLivedExecutor` repeatedly (20 times), it succeeded.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 63943: Renamed `TaskStatusEq()` to
`TaskStatusTaskIdEq()`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63943/#review191481
-----------------------------------------------------------
FAIL: mesos-java failed to build.
Reviews applied: `['63577', '63943']`
Failed command: `cmake.exe --build . --target mesos-java`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63943
Relevant logs:
- [mesos-java-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63943/logs/mesos-java-build-cmake-stdout.log):
```
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
c:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
c:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"C:\DCOS\mesos\src\mesos-java.vcxproj" (default target) (1) ->
"C:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (19) ->
(ClCompile target) ->
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\http.cpp(1984): error C2664: 'void hashmap<int,process::http::ServerProcess::Client,std::hash<int>,std::equal_to<Key>>::put(const Key &,const Value &)': cannot convert argument 1 from 'const process::network::Socket' to 'const int &' [C:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\http.cpp(1988): error C2664: 'unsigned __int64 std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::erase(const int &)': cannot convert argument 1 from 'const process::network::Socket' to 'std::_List_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const _Kty,_Ty>>>>' [C:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
326 Warning(s)
2 Error(s)
Time Elapsed 00:42:30.07
```
- [mesos-java-build-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63943/logs/mesos-java-build-CMakeOutput.log):
```
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_7ef70.dir\Debug\cmTC_7ef70.tlog\".
InitializeBuildStatus:
Creating "cmTC_7ef70.dir\Debug\cmTC_7ef70.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_7ef70.dir\Debug\" /Fd"cmTC_7ef70.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_7ef70.dir\Debug\" /Fd"cmTC_7ef70.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_7ef70.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_7ef70.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_7ef70.lib" /MACHINE:X64 /machine:x64 cmTC_7ef70.dir\Debug\src.obj
cmTC_7ef70.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_7ef70.exe
cmTC_7ef70.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_7ef70.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_7ef70.dir\Debug\cmTC_7ef70.tlog\unsuccessfulbuild".
Touching "cmTC_7ef70.dir\Debug\cmTC_7ef70.tlog\cmTC_7ef70.lastbuildstate".
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7ef70.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.94
Source file was:
int main() { return 0; }
```
- [mesos-java-build-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63943/logs/mesos-java-build-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_83b8f.dir\Debug\".
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_83b8f.dir\Debug\cmTC_83b8f.tlog\".
InitializeBuildStatus:
Creating "cmTC_83b8f.dir\Debug\cmTC_83b8f.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_83b8f.dir\Debug\" /Fd"cmTC_83b8f.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_83b8f.dir\Debug\" /Fd"cmTC_83b8f.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_83b8f.vcxproj]
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_83b8f.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_83b8f.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_83b8f.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.13
```
- Mesos Reviewbot Windows
On Nov. 20, 2017, 10:44 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63943/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2017, 10:44 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
> src/tests/mesos.hpp 345b883a8c629bf5bed83e9236632c277f2eb0eb
>
>
> Diff: https://reviews.apache.org/r/63943/diff/1/
>
>
> Testing
> -------
>
> Manually ran the test `MasterTest.MasterFailoverLongLivedExecutor` repeatedly (20 times), it succeeded.
>
>
> Thanks,
>
> Qian Zhang
>
>