You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2016/07/06 21:28:32 UTC
[GitHub] spark pull request #14077: [SPARK-16402] [SQL] JDBC Source: Implement save A...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/14077
[SPARK-16402] [SQL] JDBC Source: Implement save API
#### What changes were proposed in this pull request?
Before this PR, we are unable to call the `save` API of `DataFrameWriter` when the source is JDBC. For example,
```Scala
df.write
.format("jdbc")
.option("url", url1)
.option("dbtable", "TEST.TRUNCATETEST")
.option("user", "testUser")
.option("password", "testPass")
.save()
```
The error message users will get is like
```
org.apache.spark.sql.execution.datasources.jdbc.JdbcRelationProvider does not allow create table as select.
java.lang.RuntimeException: org.apache.spark.sql.execution.datasources.jdbc.JdbcRelationProvider does not allow create table as select.
```
At the same time, users can do it for the other data sources, like `parquet`
This PR is to implement `createRelation` of `CreatableRelationProvider`. After the changes, we can use `save` API of `DataFrameWriter`.
#### How was this patch tested?
Added test cases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark jdbcSave
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14077.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14077
----
commit 732e592ccaab9b8105fab8dbd57c66eff067a4f4
Author: gatorsmile <ga...@gmail.com>
Date: 2016-07-06T19:36:30Z
jdbc.
commit 1b4db1ad59ec59275f6d5ac9f8479b16072e9bc8
Author: gatorsmile <ga...@gmail.com>
Date: 2016-07-06T21:17:15Z
fix
commit 50c9de85fd76a87caa4eb432c74cb9717d48f9e6
Author: gatorsmile <ga...@gmail.com>
Date: 2016-07-06T21:18:48Z
revert
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by JustinPihony <gi...@git.apache.org>.
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14077
@gatorsmile If `copy` is a bug, then that is fine with me (I just commented my findings on this and will be curious to hear back). That said, it would make my implementation simpler. I'd be fine with simplifying it down to a basic save, however I am still not OK with the circular reference. It adds confusion to debugging and future refactorings. And to fix that, you end up back at my PR. So, ultimately this still seems like a duplicate to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
@JustinPihony How about you first moving the `copy` function in your PR now? Then, we can review your PR before the SPARK-16401 is resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
Sure, let me close it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14077
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by JustinPihony <gi...@git.apache.org>.
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14077
Thanks. I will have to wait until SPARK-16401 is resolved or else the code will not pass tests, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by JustinPihony <gi...@git.apache.org>.
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14077
This may seem simpler, but that's because it seems to be taking some shortcuts to avoid having to refactor. This currently creates a cycle along the lines of `df.save.df.jdbc`. Wouldn't it be better to fix the code than to work around it? Additionally, is moving the `copy` appropriate? Maybe it was put on the outside errantly and it is correct, but I'm not sure it can be moved without researching it properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #61867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61867/consoleFull)** for PR 14077 at commit [`50c9de8`](https://github.com/apache/spark/commit/50c9de85fd76a87caa4eb432c74cb9717d48f9e6).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #64805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64805/consoleFull)** for PR 14077 at commit [`2e799ce`](https://github.com/apache/spark/commit/2e799ce86652bc5c03d21fdbf0a11fab20b37c39).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #64806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64806/consoleFull)** for PR 14077 at commit [`07e3168`](https://github.com/apache/spark/commit/07e316823ed17e89c3df0aaccf3fbb958afcfe3a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
@dongjoon-hyun I assume what you are saying is about `insertInto` API. Here, this PR is to implement the `save` API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by JustinPihony <gi...@git.apache.org>.
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14077
Then the best course of action would be to use my current impl as it works no matter the position of copy. I can add the additional tests if that would make it more amenable? Otherwise I'll push a reduced code set in the morning, but it would rely on the copy location move PR
> On Jul 7, 2016, at 1:27 AM, Hyukjin Kwon <no...@github.com> wrote:
>
> (Personally, I hope this does not get delayed because this usage was introduced in Spark Summit PPT and I guess users would try to use this API.)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64806/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #64806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64806/consoleFull)** for PR 14077 at commit [`07e3168`](https://github.com/apache/spark/commit/07e316823ed17e89c3df0aaccf3fbb958afcfe3a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14077
Hi, @gatorsmile . Sorry for bothering you. :)
May I ask a question? I'm a little bit confused because I made a PR for `JDBCWriteSuite.scala` before.
For me, it seemed to work for H2 in-memory DB through JDBC.
According to this PR, you mean that was not working until now, don't you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by JustinPihony <gi...@git.apache.org>.
Github user JustinPihony commented on the issue:
https://github.com/apache/spark/pull/14077
@gatorsmile As I said above, I actually think it might be better to keep the work that was already done and am waiting for Reynold's feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
@JustinPihony You know, I do not care which PR is merged eventually. You can try to clean your PR at your best. I will review your PR when it is ready. Thanks for your work! Please continue to submit more PRs for improving Spark.
To reduce the code changes in your PR, I think we should not extend `SchemaRelationProvider`. Now, I think you can assume the copy location has been fixed.
Since this is related to Data Source APIs, CC @rxin @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #64805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64805/consoleFull)** for PR 14077 at commit [`2e799ce`](https://github.com/apache/spark/commit/2e799ce86652bc5c03d21fdbf0a11fab20b37c39).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14077
(Personally, I hope this does not get delayed because this usage was introduced in Spark Summit PPT and I guess users would try to use this API.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
@JustinPihony Thanks for your review! Let me try to answer your concerns.
- The `copy` function location is actually a bug. See another PR: https://github.com/apache/spark/pull/14075.
- The trait `CreatableRelationProvider` was introduced for the `save` API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14077
**[Test build #61867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61867/consoleFull)** for PR 14077 at commit [`50c9de8`](https://github.com/apache/spark/commit/50c9de85fd76a87caa4eb432c74cb9717d48f9e6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14077
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14077: [SPARK-16402] [SQL] JDBC Source: Implement save A...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/14077
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14077
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64805/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
@HyukjinKwon uh... I did not realize there exists such a PR. I think the implementation of this PR is much simple. We can close #12601 after this is merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14077
Thank you for confirming that it is a bug in another PR.
Regarding the solution of this PR, it is not a true circular reference. The solution in this PR is to minimize the duplicate codes. I also think it make senses to move the common code logics from `jdbc` API to `createRelation` implementation of `CreatableRelationProvider`. The JDBC-specific logics should not be exposed to the `DataFrameWriter` APIs.
If you wants to do it in your PR, I am also fine. Please minimize the code changes and add the test cases introduced in this PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14077
@gatorsmile Just a reminder that we might be able to close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61867/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14077
I guess this is a duplicate of https://github.com/apache/spark/pull/12601. Maybe we should fix the title and add `Closes #12601` in the PR description (I think this one is cleaner than the original one anyway).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14077
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org