You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/28 17:37:09 UTC

[GitHub] [druid] ccaominh opened a new pull request #10446: Compaction config UI optional numShards

ccaominh opened a new pull request #10446:
URL: https://github.com/apache/druid/pull/10446


   ### Description
   
   Specifying `numShards` for hashed partitions is no longer required after https://github.com/apache/druid/pull/10419. Update the UI make`numShards` an optional field for hash partitions.
   
   #### Compaction config UI
   ![compaction-config-optional-num-shards](https://user-images.githubusercontent.com/9208416/94331910-4b765180-ff85-11ea-924a-5a8c30f28ff0.png)
   
   #### Data loader UI
   ![data-loader-partition-optional-num-shards](https://user-images.githubusercontent.com/9208416/94331914-53ce8c80-ff85-11ea-8cde-1f14d05d163d.png)
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky merged pull request #10446: Compaction config UI optional numShards

Posted by GitBox <gi...@apache.org>.

vogievetsky merged pull request #10446:
URL: https://github.com/apache/druid/pull/10446


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org