You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sydykov (via GitHub)" <gi...@apache.org> on 2023/02/01 13:52:24 UTC
[GitHub] [airflow] sydykov commented on a diff in pull request #27616: Flush the session in `handle_failure()` prior to invoking callbacks
sydykov commented on code in PR #27616:
URL: https://github.com/apache/airflow/pull/27616#discussion_r1093252632
##########
airflow/models/taskinstance.py:
##########
@@ -1808,13 +1808,13 @@ def handle_failure(
except Exception:
self.log.exception("Failed to send email to: %s", task.email)
- if callback and context:
- self._run_finished_callback(callback, context, callback_type)
-
if not test_mode:
session.merge(self)
session.flush()
+ if callback and context:
+ self._run_finished_callback(callback, context, callback_type)
+
Review Comment:
@ephraimbuddy, hello. I am still traveling and haven't had a chance to get back to this yet, unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org