[GitHub] [trafficserver] ywkaras commented on pull request #9647: 9.2.x: Fix an error on SSL config reload (plus some cleanup). (#9334)

["ywkaras (via GitHub)" <gi...@apache.org>]

ywkaras commented on PR #9647:
URL: https://github.com/apache/trafficserver/pull/9647#issuecomment-1531941350

   > PR for master. #9334 Thread on dev@ https://lists.apache.org/thread/t4wysyq55c6nt3oxg3skybb8t4klj4n2
   > 
   > Trying to summarize the changes on this PR. Does this list look correct?
   > 
   > * Removes TSSslSecretSet, TSSslSecretGet, and TSSslSecretUpdate
   > * Removes TS_LIFECYCLE_SSL_SECRET_HOOK
   > * Keep the value of TS_LIFECYCLE_LAST_HOOK for compatibility (?)
   > * Fixes thread unsafety due to returning pointers for secret data in unorderd_map
   > 
   > Removing ssl_secret_load_test.cc makes sense because it uses the removed APIs, but why some other tests are removed as well?
   
   Yes, that's a good summary.  I preserved the value of TS_LIFECYCLE_LAST_HOOK just as a precaution.  All of the deleted Au tests used ssl_secret_load_test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org