You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/06/03 03:17:46 UTC
Review Request 70775: Added `ipc_mode` and `shm_size` fields into
`LinuxInfo`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9788
https://issues.apache.org/jira/browse/MESOS-9788
Repository: mesos
Description
-------
Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
Diffs
-----
include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d
include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44
Diff: https://reviews.apache.org/r/70775/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into
`LinuxInfo`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/#review215642
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70773, 70774, 70775]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 3, 2019, 3:17 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70775/
> -----------------------------------------------------------
>
> (Updated June 3, 2019, 3:17 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d
> include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44
>
>
> Diff: https://reviews.apache.org/r/70775/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into
`LinuxInfo`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/
-----------------------------------------------------------
(Updated June 20, 2019, 2:04 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-9827
https://issues.apache.org/jira/browse/MESOS-9827
Repository: mesos
Description
-------
Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
Diffs (updated)
-----
include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9
include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e
Diff: https://reviews.apache.org/r/70775/diff/2/
Changes: https://reviews.apache.org/r/70775/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into
`LinuxInfo`.
Posted by Qian Zhang <zh...@gmail.com>.
> On June 20, 2019, 8:44 a.m., Gilbert Song wrote:
> > include/mesos/mesos.proto
> > Lines 3269-3270 (patched)
> > <https://reviews.apache.org/r/70775/diff/1/?file=2147578#file2147578line3269>
> >
> > delete: with a possibility to share them with its child containers
> >
> > Is a nested container allowed to have its own ipc namespace and /dev/shm?
I would suggest to keep `"with a possibility to share them with its child containers"`, actually Docker has something similar, see `--ipc=shareable` in https://docs.docker.com/engine/reference/run/#ipc-settings---ipc
> Is a nested container allowed to have its own ipc namespace and /dev/shm?
Yes.
> On June 20, 2019, 8:44 a.m., Gilbert Song wrote:
> > include/mesos/mesos.proto
> > Lines 3279 (patched)
> > <https://reviews.apache.org/r/70775/diff/1/?file=2147578#file2147578line3279>
> >
> > s/do it/ share from the agent's/g
The word `share from the agent's` makes the whole sentence a bit redundant, so I would suggest to keep the word `do it`.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/#review215974
-----------------------------------------------------------
On June 7, 2019, 7:23 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70775/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 7:23 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9827
> https://issues.apache.org/jira/browse/MESOS-9827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d
> include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44
>
>
> Diff: https://reviews.apache.org/r/70775/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into
`LinuxInfo`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/#review215974
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/mesos.proto
Lines 3269-3270 (patched)
<https://reviews.apache.org/r/70775/#comment302899>
delete: with a possibility to share them with its child containers
Is a nested container allowed to have its own ipc namespace and /dev/shm?
include/mesos/mesos.proto
Lines 3273 (patched)
<https://reviews.apache.org/r/70775/#comment302893>
s/with/from/g
include/mesos/mesos.proto
Lines 3275 (patched)
<https://reviews.apache.org/r/70775/#comment302894>
s/with/from/g
include/mesos/mesos.proto
Lines 3277 (patched)
<https://reviews.apache.org/r/70775/#comment302895>
ditto
include/mesos/mesos.proto
Lines 3278 (patched)
<https://reviews.apache.org/r/70775/#comment302896>
ditto
include/mesos/mesos.proto
Lines 3279 (patched)
<https://reviews.apache.org/r/70775/#comment302897>
s/do it/ share from the agent's/g
include/mesos/mesos.proto
Lines 3289 (patched)
<https://reviews.apache.org/r/70775/#comment302907>
period `.` at the end.
include/mesos/mesos.proto
Lines 3290-3294 (patched)
<https://reviews.apache.org/r/70775/#comment302908>
Can we split into different sentences to make it more clear?
include/mesos/mesos.proto
Lines 3296 (patched)
<https://reviews.apache.org/r/70775/#comment302909>
s/handling/support/g
include/mesos/mesos.proto
Lines 3297 (patched)
<https://reviews.apache.org/r/70775/#comment302910>
s/,/./g
include/mesos/mesos.proto
Lines 3299-3301 (patched)
<https://reviews.apache.org/r/70775/#comment302911>
add `()` to i.e.,...
include/mesos/v1/mesos.proto
Lines 3259 (patched)
<https://reviews.apache.org/r/70775/#comment302912>
ditto
- Gilbert Song
On June 6, 2019, 4:23 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70775/
> -----------------------------------------------------------
>
> (Updated June 6, 2019, 4:23 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9827
> https://issues.apache.org/jira/browse/MESOS-9827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d
> include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44
>
>
> Diff: https://reviews.apache.org/r/70775/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into
`LinuxInfo`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/
-----------------------------------------------------------
(Updated June 7, 2019, 7:23 a.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9827
https://issues.apache.org/jira/browse/MESOS-9827
Repository: mesos
Description
-------
Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
Diffs
-----
include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d
include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44
Diff: https://reviews.apache.org/r/70775/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into
`LinuxInfo`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/#review215639
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70773, 70774, 70775]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 2, 2019, 8:17 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70775/
> -----------------------------------------------------------
>
> (Updated June 2, 2019, 8:17 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d
> include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44
>
>
> Diff: https://reviews.apache.org/r/70775/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>