You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/11 04:28:30 UTC
[GitHub] [calcite] zhztheplayer commented on a change in pull request #1011:
[CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION
zhztheplayer commented on a change in pull request #1011: [CALCITE-2721] Support parsing of DOT + MEMBER_FUNCTION
URL: https://github.com/apache/calcite/pull/1011#discussion_r264088987
##########
File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
##########
@@ -7385,6 +7387,24 @@ public void subTestIntervalSecondFailsValidation() {
"(?s).*Encountered \"from\" at .*");
}
+ /**
+ * Tests that applying member function of a specific type as a suffix function
+ */
+ @Test public void testMemberFunction() {
+ check("SELECT myColumn.func(a, b) FROM tbl",
Review comment:
Firstly, thank your for keeping working on this, @walterddr!
Comment of this line:
As the expression is written as `myColumn.func(...)`, shouldn't it be parsed to a DOT expression? But by looking into the generated parse tree I think the result is more like a `schema.func(...)` (see following).
!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services