[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6120: server: fix NPE when router.service.offering is set due to service/disk offering refactoring

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #6120:
URL: https://github.com/apache/cloudstack/pull/6120#discussion_r828826126



##########
File path: server/src/main/java/org/apache/cloudstack/network/router/deployment/VpcRouterDeploymentDefinition.java
##########
@@ -14,7 +14,7 @@
 // KIND, either express or implied.  See the License for the
 // specific language governing permissions and limitations
 // under the License.
-package org.cloud.network.router.deployment;
+package org.apache.cloudstack.network.router.deployment;

Review comment:
       @nvazquez 
   in cloudstack codebase, old java classes are in package `com.cloud.xx.xx` ,  new java classes are in package `org.apache.cloudstack.xx.xx`
   
   these classes are in packages `org.cloud.xx.xx` which are not correct I think. therefore move to `org.apache.cloudstack`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org