[jira] [Resolved] (MATH-1555) Wrong declaration of ATan2 class

["Gilles Sadowski (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MATH-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gilles Sadowski resolved MATH-1555.
-----------------------------------
    Fix Version/s: 4.0
       Resolution: Fixed

Fixed in commit 27f289f6be1396893247f13225a52388f598a8d7 ("master" branch).
Thanks for the report.

> Wrong declaration of ATan2 class
> --------------------------------
>
>                 Key: MATH-1555
>                 URL: https://issues.apache.org/jira/browse/MATH-1555
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Laurent Galluccio
>            Priority: Major
>             Fix For: 4.0
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> If i check the content of ATan2 class, the value method is coded like this 
> public double value(double x, double y) {
>  return FastMath.atan2(x, y);
>  }
> with 
> *x* Abscissa for which the function value should be computed.
> *y* Ordinate for which the function value should be computed.
>  
> But the FastMath.atan2 method is declared like this 
> /**
>  * Two arguments arctangent function
>  * @param y ordinate
>  * @param x abscissa
>  * @return phase angle of point (x,y) between \{@code -PI} and \{@code PI}
>  */
>  public static double atan2(double y, double x) 
>  
> Which means that ordinate and abscissa are inverted. This should be fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)